Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_status: Show change status modal when clicked on emoji in buddy list. #19515

Merged
merged 2 commits into from Aug 7, 2021

Conversation

ganpa3
Copy link
Collaborator

@ganpa3 ganpa3 commented Aug 5, 2021

Fixes #19506

(For some reason, directly passing the selector to the existing handler doesn't work)

GIFs or screenshots:
clicking_emoji_brings_status

@zulipbot
Copy link
Member

zulipbot commented Aug 5, 2021

Hello @zulip/server-sidebars members, this pull request was labeled with the "area: right-sidebar" label, so you may want to check it out!

static/js/popovers.js Outdated Show resolved Hide resolved
@ganpa3 ganpa3 force-pushed the clicking_emoji_brings_status branch 2 times, most recently from 77139df to 089775a Compare August 6, 2021 15:22
@ganpa3 ganpa3 force-pushed the clicking_emoji_brings_status branch from 089775a to 2e4c82f Compare August 7, 2021 05:48
@timabbott timabbott merged commit 378395b into zulip:master Aug 7, 2021
@timabbott
Copy link
Sponsor Member

Merged, thanks @ganpa3!

@ganpa3 ganpa3 deleted the clicking_emoji_brings_status branch August 7, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make user's own status emoji link to status editor
3 participants