Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip: Download tooltip on file. #19805

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

isakhagg
Copy link
Collaborator

@isakhagg isakhagg commented Sep 22, 2021

Fixes #19740

Testing plan:
Visualtesting and automatic tests.

GIFs or screenshots:
bild

@isakhagg
Copy link
Collaborator Author

@alexmv or @timabbott Could you have a look at this PR? It fixes issue #19740

@timabbott timabbott force-pushed the download_uploaded_file_tooltip-19740 branch from 3a4743a to 9d291c9 Compare September 27, 2021 17:54
@timabbott timabbott merged commit 9d291c9 into zulip:main Sep 27, 2021
@timabbott
Copy link
Sponsor Member

This is great @isakhagg! I merged this after a few minor changes:

  • Adjusted the commit message to close Show "Download <filename>..." tooltip on uploaded file links #19740.
  • Added a comment explaining the motivation for this block of code.
  • Renamed the variable in the string from variable to filename, since that's more naturally helpful, both for reading the code and for the dozens of translators who will end up translating this string into their language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "Download <filename>..." tooltip on uploaded file links
3 participants