compose: Add stream privacy decorations in banner box.

[srdeotarse]

This PR is for issue #19878
Fixes part (1/2) -
Add stream privacy decorations in banner box.

Part (2/2) in another PR as suggested by @alya in Zulip chat https://chat.zulip.org/#narrow/stream/9-issues/topic/missing.20hash.20before.20stream.20name/near/1261461 -
Add stream privacy decorations in compose box.

Testing plan:
Lint test.
Node test.

GIFs or screenshots:

Changes explained:

Earlier sent message notification - "Sent! Your message is outside current narrow. Narrow to test > blue"

Updated sent message notification - "Sent! Your message is outside current narrow. Narrow to #test > blue"

[alya]

Hm, that hash looks overly large to me.

Could you also:

1. Add screenshots for a private stream and a world public stream?
2. Make sure your PR passes checks.

Thanks!

[srdeotarse]

Hm, that hash looks overly large to me.

Could you also:

1. Add screenshots for a private stream and a world public stream?
2. Make sure your PR passes checks.

Thanks!

Yes, I will adjust the hash size and also add screenshots for mentioned cases.
I will make sure that my PR passes checks as well.

Thanks for reviewing my PR.

[srdeotarse]

Hm, that hash looks overly large to me.

Could you also:

1. Add screenshots for a private stream and a world public stream?
2. Make sure your PR passes checks.

Thanks!

Fix vertical alignment and size of stream privacy decoration icons in banner box.

Screenshots-

Public stream -

Private stream -

Web Public stream-

[raghupalash]

Thanks for working on this @srdeotarse! I have a review regarding the commits.
Your commit messages don't comply with the commit discipline guide.

Also you might want to clean up your commit history, check out - https://zulip.readthedocs.io/en/latest/git/fixing-commits.html.

Goodday! 😸 🐋

[srdeotarse]

@raghupalash I have cleaned my commit history and changed commit messages according to commit guidelines.

[alya]

Thanks! It looks to me like there's not enough spacing to the left of the lock and globe icons -- there should be as much space as you normally have between words.

For the hash, can we try having less space between the # and the name of the stream?

[srdeotarse]

Thanks! It looks to me like there's not enough spacing to the left of the lock and globe icons -- there should be as much space as you normally have between words.

For the hash, can we try having less space between the # and the name of the stream?

Adjusted spacing to the left of globe and lock icons in banner box. Also, reduced spacing between # and name of stream.

[alya]

@srdeotarse Could you add updated screenshots here? Thanks!

[srdeotarse]

@alya Adding the updated screenshots -

Added spacing to the left of lock icon -

Added spacing to the left of globe icon -

Reduced spacing between hash and stream name -

[raghupalash]

@raghupalash I have cleaned my commit history and changed commit messages according to commit guidelines.

I think you'd want to squash all the commits in one single commit (as they all belong to a single change). This might help https://zulip.readthedocs.io/en/latest/git/fixing-commits.html#fixing-the-last-commit. Feel free to bump a thread on the development-help stream if you can't figure it out.

[raghupalash]

is_invite_only_by_stream_name function on line 582 does the exact same thing as this, infact is_invite_only_by_stream_name was formerly named as get_invite_only and renamed by Tim on commit 3f4d66109be0265a45713419bbee14394c98414f. So I think we should use the already available helper method instead of making a new one.

[srdeotarse]

I have removed get_invite_only function and used is_invite_only_by_stream_name.

[raghupalash]

I think $t was used here for translation purposes, so I think we should still stick with using it, plus I don't think your implementation requires you to remove it anyways, you can just let that line be and use it in the compose_notification template as it was used before with your additional changes.

[srdeotarse]

Now I have used $t along with my changes.

[alya]

@amanagr perhaps you could review and/or finish up this PR as well?

[amanagr]

I pushed the commits from #20588 here as well so that they are easier to merge and review.

[amanagr]

I removed the underline on link hover since it was not playing nicely with the icons. It just has an increased opacity effect on hover now.

Compose decorations and banner decorations.

[amanagr]

@srdeotarse please fetch this PR locally and change author of the last 2 commits to yourself.

[srdeotarse]

@amanagr I have changed the author of the last two commits to me.

[amanagr]

@srdeotarse did you review the changes I made? Do they look good to you?

[srdeotarse]

@amanagr Yes, separate classes for lock_icon and globe_icon will be helpful for future use as well. Also, my commit from other closed PR is quite similar to this PR, so it makes sense to use them in this PR.

[alya]

Thanks for updating this!

I'm not sure about the globe and lock, but the font on # looks odd to me. Could we make it less bold to match the rest of the text?

[alya]

Seeing the icons added, it now feels odd not to have the appropriate stream privacy icon in a couple of other places in the compose box area:

• The "Message..." button
  

• The "Message..." placeholder text
  

Would it be possible to make these be based on the stream privacy setting as well?

[zulipbot]

Heads up @srdeotarse, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

[alya]

@srdeotarse , will you have time to address the remaining feedback on this PR, or should @amanagr take over from here?

[alya]

Let's just complete the banner icon changes in this PR.