Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onboarding: Fix formatting of registration page buttons. #20578

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

onboarding: Fix formatting of registration page buttons. #20578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/styles/portico/portico_signin.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ html {
button.login-social-button {
width: 328px;
height: auto;
padding-left: 35px;
padding-left: 60px;
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this works, this doesn't seem like the sort of clean fix that would avoid future regressions.

Or maybe it is -- how did you pick 60px? Is there math on the size of elements we should be using instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timabbott Yes, I did calculate for 'Sign up with Google' button, the background-position is 13px (from the left edge of the button), and the logo's height is 60% of the button, i.e. 45px * 0.6 = 27px. Thus, the width of the logo is (27/76)*74 = 26px approximately (The original size of the logo is 74 × 76 px). Now, the '.new-style button' had a 22px padding on the right of the text. So, to center the text between the right edge of the logo and the right edge of the button and to have an equal space to the left of the text (i.e. 22px) , the padding should be = 13px + 26px + 22px = 61px. I visually adjusted it to 60px as other logos had slightly different aspect ratios.

image

image

image

image

@alya

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @timabbott @alya I would love to address any other concerns you have. Please review so that I can work on new issues.. Thanks!

line-height: 1;

background-size: auto 60%;
Expand Down