Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive stream: Update modal text. #22662

Merged
merged 1 commit into from
Aug 5, 2022
Merged

archive stream: Update modal text. #22662

merged 1 commit into from
Aug 5, 2022

Conversation

ganpa3
Copy link
Collaborator

@ganpa3 ganpa3 commented Aug 4, 2022 •
edited
Loading

Fixes #22658.

Screenshots and screen captures:

Private stream

image

Web public stream

image

Public stream

image

@zulipbot zulipbot added size: S area: popovers Popovers, including general message actions. area: channel settings labels Aug 4, 2022
@zulipbot
Copy link
Member

zulipbot commented Aug 4, 2022

Hello @zulip/server-streams members, this pull request was labeled with the "area: stream settings" label, so you may want to check it out!

@alya
Copy link
Contributor

alya commented Aug 4, 2022

Nice! I think we need more space before and after the stream symbols. @amanagr I remember you working on that sort of thing -- do you have any helpful pointers?

@alya
Copy link
Contributor

alya commented Aug 4, 2022

Looking at those screenshots, let's also remove the word "stream" from the heading; I don't think we need it after the stream symbol has been added.

@ganpa3 ganpa3 force-pushed the archive_stream_modal_text_update branch from df5bc8a to ed8d48c Compare August 4, 2022 18:04
@ganpa3
Copy link
Collaborator Author

ganpa3 commented Aug 4, 2022

Looking at those screenshots, let's also remove the word "stream" from the heading; I don't think we need it after the stream symbol has been added.

Done.

@timabbott
Copy link
Sponsor Member

We need some space between the privacy icon and the stream name. Also static/templates/stream_privacy.hbs may help simplify the logic.

@ganpa3
Copy link
Collaborator Author

ganpa3 commented Aug 5, 2022

We need some space between the privacy icon and the stream name. Also static/templates/stream_privacy.hbs may help simplify the logic.

Done. Updated the PR description.

@ganpa3 ganpa3 force-pushed the archive_stream_modal_text_update branch from ed8d48c to d14a63a Compare August 5, 2022 14:48
@timabbott timabbott merged commit 5697f7f into zulip:main Aug 5, 2022
@timabbott
Copy link
Sponsor Member

Merged, thanks @ganpa3!

@ganpa3 ganpa3 deleted the archive_stream_modal_text_update branch August 6, 2022 03:24
@dmenz dmenz mentioned this pull request Dec 2, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: channel settings area: popovers Popovers, including general message actions. size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve wording for "Archive stream" confirmation modal
4 participants
@ganpa3 @zulipbot @alya @timabbott