Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: Migrate pm_conversations module to typescript. #26384

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

Lalit3716
Copy link
Collaborator

  • Migrates pm_conversations.js module to typescript.
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@Lalit3716 Lalit3716 changed the title ts: Migrate pm_conversations module to typescript. [WIP] ts: Migrate pm_conversations module to typescript. Jul 30, 2023
@Lalit3716 Lalit3716 changed the title [WIP] ts: Migrate pm_conversations module to typescript. ts: Migrate pm_conversations module to typescript. Jul 30, 2023
@zulipbot zulipbot added buddy review GSoC buddy review needed. mentor review GSoC mentor review needed. labels Jul 30, 2023
web/src/pm_conversations.ts Outdated Show resolved Hide resolved
@Lalit3716
Copy link
Collaborator Author

This is ready for another look. @PIG208

@PIG208
Copy link
Member

PIG208 commented Aug 8, 2023

Thanks! This looks good to me. I have nothing else to add.

@PIG208

This comment was marked as resolved.

@zulipbot zulipbot added integration review Added by maintainers when a PR may be ready for integration. and removed buddy review GSoC buddy review needed. mentor review GSoC mentor review needed. labels Aug 8, 2023
@timabbott timabbott merged commit 119f581 into zulip:main Aug 8, 2023
8 checks passed
@timabbott
Copy link
Sponsor Member

Merged, thanks @Lalit3716!

@Lalit3716 Lalit3716 deleted the pm_conversations_ts branch August 9, 2023 01:39
@andersk andersk added the area: typescript migration Issues for migrating Zulip to TypeScript label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript migration Issues for migrating Zulip to TypeScript integration review Added by maintainers when a PR may be ready for integration. size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants