-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new conversation: Show correct tooltip when dms are disabled. #30132
Conversation
Since this PR hasn't been reviewed yet, please ping your buddy to take a look. |
@PieterCK Please review this PR. |
ERROR: Label "buddy review" already exists and was thus not added to this pull request. |
Hi Kenneth, nice work here. code LGTM, but left a suggestion. Other than that, the PR description could probably be clearer if you add a clip of the new behavior though, so here's one I took when testing. Feel free to add it to the PR description! Screencast.from.05-06-24.22.10.26.webmLet me know if you have any questions 👍 Manually tested and found that the expected result described in #29916 has been achieved. |
Thanks @PieterCK, I'm not sure how to download and reupload your screen capture to the description, could you please help me. : ) |
Thanks for the review, @PieterCK ! When the PR looks good to you, you can remove the "buddy review" label via Zulipbot. @kennethnrk you can then add a "mentor review" label and ping your mentor. |
@kennethnrk I think you can right-click on my clip, choose "Save Video As ..." and then it should download. I'm using Firefox though, do you have that functionality in your browser? @zulipbot remove "buddy review" |
Oh, wait. I think you want to add a commit description explaining the reasoning behind the change and why it fixes the issue and better than the current state. Probably something like: For example, here's a good one from Tim! It's from one of your previous PR 👍 |
I'm using Brave, when i clicked save video it was giving me a message |
Thanks @PieterCK, I've made the changes. |
@zulipbot add "mentor review" |
It looks like you added the details that belong in the commit message in the PR description. Since it's commits, not PRs, that get merged, you want 3f4bd50 to have the context for posterity. |
And then I want to note that this text doesn't answer the key question as to how the old logic failed to do this update; it's not obvious to me from skimming. |
Earlier the `data-conversation-type` attribute of the new conversation button was being set to `direct` only if dms were enabled. As a result a stale tooltip was being shown when dms were disabled. This commit updates the attribute to `direct` reagardless of dms being enabled or not. Fixes zulip#29916.
3f4bd50
to
1536e79
Compare
I'm not sure how I overlooked that. I have updated the commit message. |
Looks great, merged, thanks @kennethnrk! |
Earlier when dms were disabled, the
new conversation
button tooltip wasn't being updated, therefore a stale tooltip was being shown.Earlier the
data-conversation-type
attribute of thenew conversation
button was being set todirect
only if dms were enabled. As a result a stale tooltip was being shown when dms were disabled.This commit updates the attribute to
direct
reagardless of dms being enabled or not.Fixes #29916.
Screenshots and screencaptures
336899046-5808aa3a-d1ea-4f41-b03f-3c5468cc144b.webm