Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zilencer: Disambiguate no MX records from the domain not existing. #30181

Merged
merged 3 commits into from
May 24, 2024

Conversation

alexmv
Copy link
Collaborator

@alexmv alexmv commented May 23, 2024

This switches to dnspython, since it offers the higher-level
resolve_name method to look up both A and AAAA records, and set
timeouts.

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@timabbott timabbott enabled auto-merge (rebase) May 23, 2024 18:38
@timabbott
Copy link
Sponsor Member

Looks good to me, marked to merge once CI passes. Thanks @alexmv!

@alexmv alexmv force-pushed the dns branch 2 times, most recently from a0f6e99 to 5d764f2 Compare May 24, 2024 15:40
@zulipbot zulipbot added size: L and removed size: M labels May 24, 2024
This switches to dnspython, since it offers the higher-level
`resolve_name` method to look up both A and AAAA records, and set
timeouts.
@timabbott timabbott merged commit e5a0b3b into zulip:main May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants