Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server_dispatch: Calculate typography vars on dense_mode. #30471

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

karlstolley
Copy link
Contributor

Owing to logic added in #30050, which accounts for the legacy line- height value, toggling dense mode requires recalculating the typography vars--otherwise, a non-legacy line-height value will not be picked up until a refresh.

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Owing to logic added in zulip#30050, which accounts for the legacy line-
height value, toggling dense mode requires recalculating the
typography vars--otherwise, a non-legacy line-height value will
not be picked up until a refresh.
@karlstolley karlstolley added bug integration review Added by maintainers when a PR may be ready for integration. area: information density Rendering and UI related to adjustable font-size, line-height labels Jun 18, 2024
@timabbott timabbott merged commit c80ffe8 into zulip:main Jun 18, 2024
7 checks passed
@timabbott
Copy link
Sponsor Member

Merged, thanks @karlstolley!

@karlstolley karlstolley deleted the dense-mode-dispatch branch July 25, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: information density Rendering and UI related to adjustable font-size, line-height bug integration review Added by maintainers when a PR may be ready for integration. size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants