Support "file:///" as hyperlink

zerver/lib/bugdown/__init__.py

@@ -634,7 +634,6 @@ def sanitize_url(url):
     except ValueError:
         # Bad url - so bad it couldn't be parsed.
         return ''
-
     # If there is no scheme or netloc and there is a '@' in the path,
     # treat it as a mailto: and set the appropriate scheme
     if scheme == '' and netloc == '' and '@' in path:
@@ -651,7 +650,7 @@ def sanitize_url(url):
     if not scheme:
         return sanitize_url('http://' + url)
 
-    locless_schemes = ['mailto', 'news']
+    locless_schemes = ['mailto', 'news', 'file']
     if netloc == '' and scheme not in locless_schemes:
         # This fails regardless of anything else.
         # Return immediately to save additional proccessing
@@ -661,7 +660,7 @@ def sanitize_url(url):
     # appears to have a netloc.  Additionally there are plenty of other
     # schemes that do weird things like launch external programs.  To be
     # on the safe side, we whitelist the scheme.
-    if scheme not in ('http', 'https', 'ftp', 'mailto'):
+    if scheme not in ('http', 'https', 'ftp', 'mailto', 'file'):
         return None
 
     # Upstream code scans path, parameters, and query for colon characters
@@ -940,12 +939,13 @@ def extendMarkdown(self, md, md_globals):
                     %s           # zero-to-6 sets of paired parens
                 )?)              # Path is optional
                 | (?:[\w.-]+\@[\w.-]+\.[\w]+) # Email is separate, since it can't have a path
+                %s
             )
             (?=                            # URL must be followed by (not included in group)
                 [!:;\?\),\.\'\"\>]*         # Optional punctuation characters
                 (?:\Z|\s)                  # followed by whitespace or end of string
             )
-            """ % (tlds, nested_paren_chunk)
+            """ % (tlds, nested_paren_chunk, r"| (?:file://(/[^/ ]*)+/?)" if settings.ENABLE_FILE_LINKS else r"")
         md.inlinePatterns.add('autolink', AutoLink(link_regex), '>link')
 
         md.preprocessors.add('hanging_ulists',

zerver/models.py

@@ -999,7 +999,7 @@ def content_has_image(content):
 
     @staticmethod
     def content_has_link(content):
-        return 'http://' in content or 'https://' in content or '/user_uploads' in content
+        return 'http://' in content or 'https://' in content or '/user_uploads' in content or 'file:///' in content
 
     def update_calculated_fields(self):
         # TODO: rendered_content could also be considered a calculated field

zproject/settings.py

@@ -159,6 +159,7 @@ def get_secret(key):
                     'REMOTE_POSTGRES_SSLMODE': '',
                     'GOOGLE_CLIENT_ID': '',
                     'DBX_APNS_CERT_FILE': None,
+                    'ENABLE_FILE_LINKS' : False,
                     }
 
 for setting_name, setting_val in DEFAULT_SETTINGS.iteritems():