added types to zerver/views/__init__.py #929
Conversation
|
Automated message from Dropbox CLA bot @dhanus, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here. |
|
Automated message from Dropbox CLA bot @dhanus, thanks for signing the CLA! |
| @@ -354,13 +359,15 @@ def json_invite_users(request, user_profile, invitee_emails=REQ()): | |||
| return json_success() | |||
|
|
|||
| def create_homepage_form(request, user_info=None): | |||
| # type: (HttpRequest) -> HomepageForm | |||
There was a problem hiding this comment.
the user_info argument is missing here
|
Thanks for doing this @dhanus! zerver/views/init.py is by a substantial margin our largest view file, so this is pretty awesome. I posted some comments on annotations that I think aren't quite right (some of which likely explain the tests failing). You can use Let me know when you have a new version ready. |
|
Looks like you still have this mypy error: |
|
I'm going to take a pass at cleaning this up for merge, since I think some of the annotations in other files that this interacts with are wrong... |
@timabbott