Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream settings: Add option to add user groups to a new stream. #9964

Closed
wants to merge 2 commits into from

Conversation

synicalsyntax
Copy link
Member

Replicates behavior of "Copy from stream". Fixes #9480.

Image from Gyazo

Replicates behavior of "Copy from stream". Fixes zulip#9480.
@zulipbot
Copy link
Member

Hello @zulip/server-streams members, this pull request was labeled with the "area: stream settings" label, so you may want to check it out!

@zulipbot zulipbot added size: L and removed size: M labels Jul 17, 2018
@YJDave
Copy link
Collaborator

YJDave commented Aug 4, 2018

@synicalsyntax Thanks for working on this.
Tested this locally. copy-from-user-group has one bug which is in copy-from-stream feature too. Opened #10193 to fix it(with bug description). In copy-from-user-group we can call the same function used in copy-from-stream.
Otherwise LGTM!

@YJDave
Copy link
Collaborator

YJDave commented Aug 7, 2018

@synicalsyntax I rebased and push your commits to #10193. I change the first user-group commit to use the generic function introduce in this commit of #10193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants