Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Updating previous deployment status incorrectly #242

Closed
emiteze opened this issue Jul 3, 2020 · 1 comment · Fixed by #308
Closed

Updating previous deployment status incorrectly #242

emiteze opened this issue Jul 3, 2020 · 1 comment · Fixed by #308
Labels
bug Something isn't working moove Improvements/additions/fixes for moove module. severity/moderate

Comments

@emiteze
Copy link
Contributor

emiteze commented Jul 3, 2020

Describe the bug
This scenario occurs only in the open sea's use case. If we do a deploy with success of a release with 5 components and then later we ask for a deploy that don't contains all components from open sea, we are updating the status of previous deploy to NOT_DEPLOYED, then resulting in a wrong payload of which components are deployed for that circle.

And we are not looking for the callback status to update previous deploy too. We should only update the previous deploy for that circle if the callback status were successfull for deploy or undeploy.

It's important to note that the virtual services probably would be ok and the deployments too, but moove does not represent what really is deployed in terms of components for open sea.

To Reproduce
Steps to reproduce the behavior:

  1. Do a successfull deploy in open sea with N components
  2. Ask for a deploy with N-1 components
  3. Note that the previous deploy containing N components will be updated to NOT_DEPLOYED.
  4. This will result in a wrong payload on circle's screen (showing only N-1 components).

Expected behavior
We should have a concise representation from what is applied on user's cluster in terms of deployments and virtual services.

@emiteze emiteze added bug Something isn't working moove Improvements/additions/fixes for moove module. labels Jul 3, 2020
@monicaribeiro
Copy link
Contributor

@monicaribeiro monicaribeiro linked a pull request Jul 20, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working moove Improvements/additions/fixes for moove module. severity/moderate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants