Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in latest SASS #4392

Closed
wants to merge 1 commit into from
Closed

Deprecation warnings in latest SASS #4392

wants to merge 1 commit into from

Conversation

kostaspt
Copy link
Contributor

@kostaspt kostaspt commented Feb 8, 2014

Latest SASS (v3.3.0.rc.2) shows the following deprecation warnings when compiling. I think my changes fix this.

DEPRECATION WARNING on line 187 of components/foundation/scss/foundation/components/_global.scss:
Assigning to global variable "$default-float" by default is deprecated.
In future versions of Sass, this will create a new local variable.
If you want to assign to the global variable, use "$default-float: left !global" instead.


DEPRECATION WARNING on line 188 of components/foundation/scss/foundation/components/_global.scss:
Assigning to global variable "$opposite-direction" by default is deprecated.
In future versions of Sass, this will create a new local variable.
If you want to assign to the global variable, use "$opposite-direction: right !global" instead.


DEPRECATION WARNING on line 9 of components/foundation/scss/foundation/components/../_functions.scss:
Assigning to global variable "$modules" by default is deprecated.
In future versions of Sass, this will create a new local variable.
If you want to assign to the global variable, use "$modules: append($modules, $name) !global" instead.

@rafibomb rafibomb added the scss label Feb 10, 2014
@paynecodes
Copy link

I'm seeing some deprecation warnings as well. My Sass still compiles, but it seems to have broken some styles as well.

@maggo
Copy link
Contributor

maggo commented Feb 12, 2014

The problem is older sass versions won't allow the !global flag that's needed here, so there's no real solution here till zurb decides to drop support for older sass versions.

@Ilyes512
Copy link
Contributor

It's a 'DEPRECATION WARNING', but if you would apply these changes then it will break SASS 3.2 and lower. You can add this to your grunt file (if you are using grunt-contrib-sass like me and everybody should instead of grunt-sass) you can add this to the options: quiet: true.

@paynecodes
Copy link

@kostaspt @Ilyes512
Can we apply these !global flags conditionally based on Sass version?

@Ilyes512
Copy link
Contributor

Not sure if there is a variable you can call from within your .scss that outputs the sass version. I guess you could do it manually: $sass-version: '3.2' and put this in settings.scss.

@rafibomb rafibomb added this to the 5.2 milestone Feb 27, 2014
@smileyj68
Copy link

Given that these are for the moment just deprecation warnings, we're not quite ready to drop older versions of Sass. I'm going to move this into the F6 milestone and we'll tackle it there. Thanks!

@smileyj68 smileyj68 modified the milestones: 6.0, 5.2 Mar 4, 2014
@thedeerchild
Copy link
Contributor

We're doing a pretty heavy re-write with the SCSS for F6, so we probably won't be able to merge this, but we'll make sure that F6 uses the !global flag and is written for SASS 3.3.

@kostaspt kostaspt deleted the deprecation-warnings-fix branch April 15, 2014 05:47
@Ne-Ne
Copy link
Contributor

Ne-Ne commented May 29, 2014

@thedeerchild, When is the expected F6 due to release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants