Adjust globals for sass 3.2 compatibility #5632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second this. Throws deprecation warnings through (ruby) sass v3.3.14 and errors in v3.4.0. Made these same changes locally and it's now working fine with v3.4.0. |
|
Unfortunately this breaks in Libsass. See sass/libsass#278 |
|
It looks like it shouldn't be an issue anymore? sass/libsass#409 Am I wrong with this assumption? |
|
Still fails for me. |
smartperson
added a commit
to smartperson/foundation-rails
that referenced
this pull request
Sep 15, 2014
This is tied to issues mentioned in: http://foundation.zurb.com/forum/posts/18856-sass-342-compilation-proble m sass/sass#1397 foundation/foundation-sites#5636 foundation/foundation-sites#5632 Since it seems to be taking time for smarter minds to come up with changes to Foundation 5 that will get it playing nice with sass 3.4, let’s at least modify the dependencies in the meantime so more users don’t update their gems and spend forever debugging a very unusual issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustments to global declarations so that Sass 3.2 doesn't throw deprecation errors/warnings when compiling to css.