Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Play button should be greyed out for unplayable platforms. #823

Closed
slimshizn opened this issue Apr 21, 2024 · 3 comments
Closed

[Bug] Play button should be greyed out for unplayable platforms. #823

slimshizn opened this issue Apr 21, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@slimshizn
Copy link

RomM version
3.1

Describe the bug
Play button is available in platforms that are not playable

To Reproduce
Steps to reproduce the behavior:

  1. Go to unplayable game in console/platform view.
  2. Click on play button.
  3. Click on Play
  4. Will sit on "Decompress game core"

Expected behavior
Play button greyed out.

@slimshizn slimshizn added the bug Something isn't working label Apr 21, 2024
@gantoine
Copy link
Member

Which platform are you trying this with, and what's the IGDB slug?

@gantoine gantoine self-assigned this Apr 21, 2024
@IvanMazzoli
Copy link

IvanMazzoli commented Apr 22, 2024

Can confirm the issue with PS1 games.
If I try to launch the game from its information page, the "Play" button is correctly greyed out:
image

But if I try to launch it from the homepage or platform page as @slimshizn said, the "Play" button is working and allows us to enter to the EmulatorJS page.
image

(Yes, I'm updating to 3.1.0 😉)

@zurdi15
Copy link
Member

zurdi15 commented Apr 22, 2024

Oh okay you are totally right, we are not managing the cards play button. Will be fixed for the next release

@zurdi15 zurdi15 assigned zurdi15 and unassigned gantoine Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants