This repository has been archived by the owner on Jun 2, 2018. It is now read-only.
Fix subclass problem (#119) #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,7 @@ @implementation UIWebView (BlocksKit) | |||
| + (void)load | |||
| { | |||
| @autoreleasepool { | |||
| [self bk_registerDynamicDelegate]; | |||
| [self bk_registerDynamicDelegateNamed:@"delegate" forProtocol:@protocol(UIWebViewDelegate)]; | |||
There was a problem hiding this comment.
It should be able to figure this out automatically.
There was a problem hiding this comment.
I got a crash in iOS 7 because it couldn't find it.
There was a problem hiding this comment.
Couldn't find what...? And why not fix the issue...?
There was a problem hiding this comment.
NSProtocolFromString(@"UIWebViewDelegate") returned nil for some reason.
There was a problem hiding this comment.
Isn't that a problem that you should diagnose?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alex can't create pull requests, apparently.