Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several changes #54

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Several changes #54

merged 3 commits into from
Dec 6, 2023

Conversation

spudwebb
Copy link

@spudwebb spudwebb commented Dec 6, 2023

  • Added Driver.SoftReset method.
  • Fixed BeginRebuildingRoutes, StopRebuildingRoutes and RebuildNodeRoutes methods to use the correct commands. Without this change the option passed in BeginRebuildingRoutes is ignored.
  • Fixed typo in RebuildRoutesDone event.

@spudwebb
Added Driver.SoftReset method.
ca07b69 
Fixed BeginRebuildingRoutes,  StopRebuildingRoutes and RebuildNodeRoutes methods to use the correct commands.
Fixed typo in RebuildRoutesDone event.
@marcus-j-davies
Copy link
Member

marcus-j-davies commented Dec 6, 2023 •
edited

Ah! Nice catches @spudwebb
will get it merged soon - Thanks

EDIT
@spudwebb - do you want to remove the old command enums for healing the network and nodes? as they are now redundant ?

@spudwebb
Copy link
Author

spudwebb commented Dec 6, 2023

@marcus-j-davies done. Thanks!

@marcus-j-davies marcus-j-davies merged commit 236b0b6 into zwave-js:4.0.0 Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spudwebb @marcus-j-davies