Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not remove controller event listeners #3767

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: do not remove controller event listeners #3767

merged 1 commit into from
Jun 12, 2024

Conversation

AlCalzone
Copy link
Member

This broke some driver-internal functionality that relied on event listeners it had previously added.

@AlCalzone AlCalzone marked this pull request as draft June 12, 2024 08:47
@AlCalzone AlCalzone marked this pull request as ready for review June 12, 2024 08:50
@robertsLando robertsLando enabled auto-merge (squash) June 12, 2024 08:51
@robertsLando robertsLando merged commit 9478c29 into master Jun 12, 2024
9 checks passed
@robertsLando robertsLando deleted the fix-controller-events branch June 12, 2024 08:52
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9479552990

Details

  • 0 of 52 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 21.143%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/lib/ZwaveClient.ts 0 52 0.0%
Totals Coverage Status
Change from base Build 9448950902: -0.02%
Covered Lines: 3899
Relevant Lines: 19612
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9479602729

Details

  • 0 of 52 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 21.141%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/lib/ZwaveClient.ts 0 52 0.0%
Totals Coverage Status
Change from base Build 9448950902: -0.02%
Covered Lines: 3899
Relevant Lines: 19614
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlCalzone @coveralls @robertsLando