Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependence on pde.tools.spherical #9

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Conversation

david-zwicker
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #9 (91672e8) into master (2126bbb) will decrease coverage by 0.59%.
The diff coverage is 83.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   90.00%   89.40%   -0.60%     
==========================================
  Files           8        9       +1     
  Lines        1340     1463     +123     
==========================================
+ Hits         1206     1308     +102     
- Misses        134      155      +21     
Flag Coverage Δ
unittests 89.40% <83.06%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
droplets/tools/spherical.py 82.92% <82.92%> (ø)
droplets/droplets.py 92.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2126bbb...91672e8. Read the comment docs.

@david-zwicker david-zwicker merged commit 8e9f0ea into master Nov 26, 2021
@david-zwicker david-zwicker deleted the no_pde_spherical branch November 26, 2021 16:19
@lgtm-com
Copy link

lgtm-com bot commented Nov 26, 2021

This pull request introduces 1 alert when merging 91672e8 into 2126bbb - view on LGTM.com

new alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant