Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boolean settings form input #321

Closed
Tracked by #317
boldar99 opened this issue Jul 11, 2024 · 1 comment
Closed
Tracked by #317

Add boolean settings form input #321

boldar99 opened this issue Jul 11, 2024 · 1 comment
Labels
good first issue Good for newcomers Priority: Low Type: enhancement New feature or request

Comments

@boldar99
Copy link
Collaborator

boldar99 commented Jul 11, 2024 •
edited
Loading

Potentially with a toggle box or toggle switch.

Steps:

  1. Add Bool to FormInputType
  2. Implement SettingsDialog.make_bool_form_input
  3. Add it to add_setting_to_form
  4. Change all the boolean settings to use the new implementation.
  5. Add hidden settings like sparkle mode and sound effects (If done)
@boldar99 boldar99 added Type: enhancement New feature or request good first issue Good for newcomers Priority: Low labels Jul 11, 2024
This was referenced Jul 11, 2024
Merged
Open
@jvdwetering
Copy link
Collaborator

This is implemented, but currently broken: the settings aren't actually saved.

@y-richie-y y-richie-y mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Priority: Low Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jvdwetering @RazinShaikh @boldar99