Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to 1.0.0 #36

Closed
MrWook opened this issue Mar 9, 2021 · 4 comments
Closed

Road to 1.0.0 #36

MrWook opened this issue Mar 9, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@MrWook
Copy link
Collaborator

MrWook commented Mar 9, 2021

At some point this project should have a full release for 1.0.0.
Therefore i places a milestone on some issues and PR that are needed to be included to minimise the Breaking changes after the release.

  • internal types should be fixed => types fixed
  • Have i Been Pwned API Support => will result in a the api change because this is async
  • add some feedback for userinput dictionaries => nice to have
  • The documentation need some spelling, grammar improvements
  • Maybe add custom matcher => would add a new option
  • add async matcher support
@MrWook MrWook added the enhancement New feature or request label Mar 9, 2021
@MrWook MrWook added this to the 1.0.0 milestone Mar 9, 2021
@MrWook MrWook pinned this issue Mar 9, 2021
@paulverbeke
Copy link

Hi,
First of all thanks a lot for this work. The original Dropbox library desperately needed maintenance.

I saw that french translations were recently added by someone, in looking into this I noticed that, no matter the language, the only feedback given when password contains an entry from the userInputs dictionary is 'There should not be any personal data.'.
Based on the original library documentation, this dictionary should also be used for site-specific vocabulary, so can I suggest that this feedback be changed to something more representative of what the dev is likely to have added, in the line of "There should not be any personal data or forbidden/banned words", or just a more general feedback ?

I can take care of updating french translations of needed.

Thanks !

@MrWook
Copy link
Collaborator Author

MrWook commented May 20, 2021

I'm all open for better translations, do you mind moving this into an own issue. Seems like a good idea but forbidden/banned words seems not to fit. As a user i would be confused if i see this. How should the user know whats forbidden or not.
Let's discuess this an the issue

@paulverbeke
Copy link

sure

@MrWook
Copy link
Collaborator Author

MrWook commented Nov 3, 2021

1.0.0 is released

@MrWook MrWook closed this as completed Nov 3, 2021
@MrWook MrWook unpinned this issue Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants