ios: expose all native result items in wrapper #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So ecLevel, version and all the other fields can be accessed from iOS apps too.
axxel
requested changes
Oct 30, 2023
Will be deprecated soon.
|
Thanks. Looks good. One thing about github usage: please don't mark review conversations as resolved if you did not start them yourself. All I saw was that all conversations were resolved and I did not even see if there was a reply from you or not without opening them first individually. |
|
Ah, I see, sorry for doing that 🙈 And thanks for merging! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
ecLevel,versionand all the other fields can be accessed from iOS apps too.