ios: improve exception handling #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `read()` throw so C++ exceptions can be caught in Swift. So an app can't crash silently anymore when a C++ exception is thrown while trying to read a barcode. This also adds a function to properly set a NSError from a C++ exception to avoid code duplication in ZXIBarcodeReader/Writer.
Because invalid GTIN data can lead to exceptions (e.g. from std::stoi), in which case we don't want to discard the whole result.
|
For my understanding: setting this |
|
Yes, exactly! Here are the details on how Cocoa error parameters are converted to Swift throwing methods. Also check out how Cocoa Errors are handled in Swift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
read()throw so C++ exceptions can be caught in Swift, so an app can't crash silently anymore when a C++ exception is thrown while trying to read a barcode.This also adds a function to properly set a NSError from a C++ exception to avoid code duplication in ZXIBarcodeReader/Writer.