Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ZydisRegisterGetLargestEnclosing #456

Merged
merged 2 commits into from Oct 9, 2023

Conversation

flobernd
Copy link
Member

Closes #443

@flobernd flobernd marked this pull request as ready for review September 30, 2023 08:29
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- looks good to me! :)

src/Register.c Outdated Show resolved Hide resolved
src/Register.c Show resolved Hide resolved
@ZehMatt
Copy link
Contributor

ZehMatt commented Oct 1, 2023

Also good opportunity to add tests for this maybe?

@flobernd flobernd requested a review from athre0z October 9, 2023 12:56
@flobernd flobernd merged commit 6ab4463 into master Oct 9, 2023
13 checks passed
@flobernd flobernd deleted the fix-enclosing-register-api branch October 9, 2023 16:10
athre0z added a commit that referenced this pull request Feb 4, 2024
This reverts the interface-breaking portion of
6ab4463.
athre0z pushed a commit that referenced this pull request Feb 4, 2024
athre0z added a commit that referenced this pull request Feb 4, 2024
This reverts the interface-breaking portion of
6ab4463.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong output of ZydisRegisterGetLargestEnclosing
3 participants