New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some questions. #1

Open

bensvage opened this issue Mar 27, 2019 · 0 comments

bensvage commented Mar 27, 2019

When we use "set" function, you let element be pushed back directly. However, due to codes in operational functions like add or subtract, it seems that you need elements to be ordered. So should it be correct that you need to reorder elements when you set a new element?
When it comes to "add" function, why "this->m_rows != mat.cols()"? shouldn't it be "!=mat.rows()" because we need't to transpose a matrix when sum two matrices together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment