-
Notifications
You must be signed in to change notification settings - Fork 184
feat(api, shared-data): Add locatingFeatureAsParent/Child
to valid entity types
#18628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
53cf0a6
to
59b6602
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18628 +/- ##
==========================================
+ Coverage 23.38% 23.67% +0.29%
==========================================
Files 3237 3240 +3
Lines 279313 280103 +790
Branches 28098 28561 +463
==========================================
+ Hits 65306 66314 +1008
+ Misses 213980 213762 -218
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea to make everything have the feature, yes. I think it is annoying to have to special case code for the underscores but it's worth it to keep the attribute names consistent. I wish the other stuff was snake case too 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐍 🐍 🐍 🐍 🐍
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18632 |
The underlying problem we now come up against is that After consulting with @SyntaxColoring , the plan is to make |
7fc08f5
to
72d03fa
Compare
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18635 |
1 similar comment
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18635 |
d5856fb
to
72d03fa
Compare
…dule defs (#18645) Works towards EXEC-77 Overview In #18628, we wanted to require locatingFeaturesAsParent for module definitions, but we couldn't (see comments in PR discussion), so we marked the field as optional and followed up with #18639. Now that the module definition issue is resolved, we can make the field required as originally intended.
Works toward EXEC-77
Overview
Adds
locatingFeaturesAsParent
andlocatingFeaturesAsChild
properties to the various entity types that may be involved in a stackup where relevant. This PR is best viewed commit-by-commit.Notably, 686e400 adds support for
locatingFeaturesAsParent
to all addressable areas. It sounds like we have to make this a required property even for the module addressable areas, because we can't rely on a child labware always resting on a parent module-based location. Down the road, this would imply that we will have duplicatedlocatingFeaturesAsParent
data between modules and addressable areas, but I suppose there's no way around this.Test Plan and Hands on Testing
Changelog
Review requests
locatingFeatureAsParent
much cleaner in our utils if the addressable area property islocatingFeatureAsParent
, camel-cased, which is consistent with the camel-casedlocatingFeaturesAsParent
present in labware defs. However, this does break the currentAddressableArea
convention of snake-casing properties. Are we ok with this or not?locatingFeatureAsParent
seem valid?Risk assessment
none