New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pyminuit and its dependencies #7081
remove pyminuit and its dependencies #7081
Conversation
please test |
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master. @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b04bad/16344/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
assign generators |
New categories assigned: generators @mkirsano,@SiewYan,@alberto-sanchez,@agrohsje,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@mkirsano,@SiewYan,@alberto-sanchez,@agrohsje,@GurpreetSinghChahal any objections on dropping |
Agreed but double-checking with the tuning people. Already pinged them. |
We (GEN-17-002) use |
Professor 1.4 had an experimental feature for taking into account covariance matrices. We should probably get the successor tool, apprentice, into CMSSW and make sure that it has all the features that we need. |
+externals |
+generators |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
to quote the pyminuit repo "Update in 2015: Guys, PyMinuit is ancient." It won't support python3, we already have professor2 rather than professor. None of these appear to be used in cmssw.