Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pyminuit and its dependencies #7081

Merged
merged 1 commit into from Jul 1, 2021

Conversation

davidlange6
Copy link
Contributor

to quote the pyminuit repo "Update in 2015: Guys, PyMinuit is ancient." It won't support python3, we already have professor2 rather than professor. None of these appear to be used in cmssw.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_12_0_X/master.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b04bad/16344/summary.html
COMMIT: 51df7cd
CMSSW: CMSSW_12_0_X_2021-06-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7081/16344/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b04bad/16344/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b04bad/16344/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785676
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

assign generators

@cmsbuild
Copy link
Contributor

New categories assigned: generators

@mkirsano,@SiewYan,@alberto-sanchez,@agrohsje,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar
Copy link
Contributor

smuzaffar commented Jun 30, 2021

@mkirsano,@SiewYan,@alberto-sanchez,@agrohsje,@GurpreetSinghChahal any objections on dropping professor from the cmssw distribution? As @davidlange6 mentioned, we already have professor2 so do we need to keep professor ?

@agrohsje
Copy link

Agreed but double-checking with the tuning people. Already pinged them.

@sensrcn
Copy link

sensrcn commented Jul 1, 2021

We (GEN-17-002) use professor only in CMSSW_9_x and 10_x releases. We don't need professor in CMSSW_12_x.

@mseidel42
Copy link
Contributor

Professor 1.4 had an experimental feature for taking into account covariance matrices.
But to be honest, it was rarely used, and this can also be hacked into Professor 2.

We should probably get the successor tool, apprentice, into CMSSW and make sure that it has all the features that we need.

@smuzaffar
Copy link
Contributor

+externals
Thanks for the feedback @cms-sw/generators-l2 . So we will go ahead and drop professor for 12.0.X
For apprentice , it is available Pypi so we should be able to include it when needed. Please open an issue in cms-sw/cmssw repo when you need this.

@smuzaffar smuzaffar merged commit c967df5 into cms-sw:IB/CMSSW_12_0_X/master Jul 1, 2021
@agrohsje
Copy link

agrohsje commented Jul 1, 2021

+generators
thanks @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2021

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants