New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable ctppsProtons for Run3 after #32352 #32356
Comments
assign reconstruction |
A new Issue was created by @slava77 Slava Krutelyov. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
@jan-kaspar |
Thanks for brining this up! I might not be the best person to ask. I am also adding @fabferro . From the perspective of the PPS reco SW, I don't see a problem to go ahead. As far as I remember, the PPS reco was disabled due to the problem #32340 - this appears in a (full) simu WF. @mundim is reponsible for PPS simu SW and he may know better. Also @clemencia may know whether the simu DB tags have already been updated. BTW: we have decided that (at least for the moment) the conditions handling from #32207 would only be used in PPS "direct" simulation. Mostly not to complicate any further the start up of the PPS full simu. |
It would be nice to get some more explicit feedback. @silviodonato |
@slava77 looking at #32340 almost all Run-3 workflows were crashing. The problem was that the crash happens after more than 100 events. |
Yes, this dataset is 11634.0 |
It's not fully clear to me why the crash happens after ~100 events. The only reason I can imagine is that no proton needs to be propagated in the first ~100 events, therefore I can't indicate a "better" workflow. |
Hi @slava77. There are two possible ways to do it, using a particle gun that shoots protons inside the acceptance of PPS or using ExHume also inside the PPS phase space. What do you prefer, I can send you a piece of configuration for either one. |
Sorry, I could not find the error messages, can you point me to them, please? Maybe I can have a more precise idea looking at them. Thanks. |
Either way (a gun or ExHume) sound fine. I was looking -- at least eventually -- for a numbered workflow in the runTheMatrix.py |
To where do you want me to send the piece of python config? Here or to your email? |
@cms-sw/pdmv-l2 |
@mundim here is the list of python configs included already in runTheMatrix. If your config is not yet there, you will need to include one (suggest at the bottom to not ruin the order of workflow ID). https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L1165 |
@chayanit Thanks. It seems the fragment is not there, but I'm afraid I have not understood the syntax to include it. I'll have a look at the other fragments to see if some adaptation is needed, but could someone give me the instructions about how to include it, please? Thanks. |
@mundim , when you have your GEN fragment, you will need add it to two place
|
@chayanit, sorry for the long time to reply. I prepared a fragment as you told above. Is there a special way to test it or just run runTheMatrix as usual? Thanks a lot |
Testing this particular wf with the new fragment, produce no errors (1 1 1 1 1 tests passed, 0 0 0 0 0 failed), but I'm not sure if the generator fragment I introduced is begin executed. |
@mundim it seems I missed the PR. Can you share the link to PR? Which command line have you tried? |
Hi @chayanit , I have not submitted the PR yet because I would like to test the fragment first. I tried first: Then I tried I ran a second time with only these ones and finally, none failed. But I'm not sure the fragment I'm trying to include is being executed. Tell me if you want me to submit the PR right away. |
from the list in #32356 (comment) I don't see how any of these can possibly include a new fragment (unless perhaps in a local test there was a manual replacement of an existing file) |
I tried already to find documentation about the runTheMatrix options, but I didn't find it, maybe I have not searched enough. I never learned what those numbers mean, if someone points me to a description about it I will really appreciate it, this will certainly not be the last time I will need it. Thank you very much. |
Just to make it clearer: I added, in a working area (CMSSW_11_3_X_2021-01-25-1100) Configuration/Generator I added the file: at the end of Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py |
I was proposing a wf starting with 116 |
ah, I guess if the number of fragments is over 100, this is 11600+125; based on what I'm guessing from 12125 |
That makes sense.. I'll try. Thank you. Can you confirm I have to include ALL the wf output by |
for now we only need a test with 2021, so, please add just 11725.0. |
Sorry, but it is still not clear to me. You asked to include the wf in the file relval_2017.py but this is not the year I suppose is the correct one, however, there is no relval_2021.py, only relval_2026.py among others like relval_upgrade.py and relval_standard.py. Which one am I supposed to include this wf? Thank you. |
Thanks @slava77 for helping here as well. @mundim could you share the list when you run I have another command to run 5 events local test you can try if your fragment works. PS. We only have this documentation for RelVal team and it might help you understand a bit how runTheMatrix works. https://twiki.cern.ch/twiki/bin/viewauth/CMS/PdmVRelValInstruction#Relval_Framework |
Thank you very much @chayanit. For your first request: ` 11925.0 2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano 11925.98 2021PU_PMXS2+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano 11925.99 2021PU_PMXS1S2+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano 12125.0 2021Design+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+Digi+Reco+HARVEST 12325.0 2021DesignPU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU 12325.98 2021DesignPU_PMXS2+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU 12325.99 2021DesignPU_PMXS1S2+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU |
For the second command, it looks like there is a problem. The output is: |
I think 11725.0 is the one you should go with as it is regular scenario of Run3 |
Not sure but have you run scram b to compile the new fragment you added? |
Yes, I did, but will make a distclean and compile again. |
No way. Don't I have to add this wf in some place? |
SORRY! There was a typo in the gen fragment. It is running. Thank you very much. |
I ran:
which produced the output:
So, I guess I can submit the PR, right? |
|
I've made #33266 but the error |
Should be fixed now by #33415 |
@slava77 , should we close this issue now? |
+reconstruction |
This issue is fully signed and ready to be closed. |
this depends on the resolution of #32340 and/or #32207
The text was updated successfully, but these errors were encountered: