Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zmumu validation tool set of commits #11195

Closed
wants to merge 9 commits into from

Conversation

usarica
Copy link
Contributor

@usarica usarica commented Sep 9, 2015

  • Updated the mass fitting scripts, integration to the All-in-One tool inside Alignment/OfflineValidation
  • Does not work under CMSSW_7_4_6_patch5, works under CMSSW_7_4_11 with no difficulty
  • Fitting and plotting scripts work for CMSSW_7_6_0_pre4, CMSSW_7_5_2 with no problems, actual cmsRun job needs to be checked after samples are available.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

A new Pull Request was created by @usarica (Ulascan Sarica) for CMSSW_7_6_X.

Zmumu validation tool set of commits

It involves the following packages:

Alignment/OfflineValidation
MuonAnalysis/MomentumScaleCalibration

@diguida, @cerminar, @monttj, @cmsbuild, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @frmeier, @argiro, @bellan, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild cmsbuild mentioned this pull request Sep 9, 2015
@mmusich
Copy link
Contributor

mmusich commented Sep 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@emiglior
Copy link
Contributor

@mabarrio, @maralxplus
This maybe relevant for you as well as it contains improvements in the macros fitting M(mu+mu-) mass slices for the validation.
The backports are: CMSSW_74X #11197 and CMSSW_75X #11196

@usarica
Copy link
Contributor Author

usarica commented Sep 10, 2015

The last commit titled "Compatibility with #10477" is supposed to fix an error from the python config file when running a job. The error was due to the deletion of some of the old models in PR #10477. No errors are seen with this version yet.

@cmsbuild
Copy link
Contributor

Pull request #11195 was updated. @diguida, @cerminar, @monttj, @cmsbuild, @vadler, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8514/console

@usarica
Copy link
Contributor Author

usarica commented Sep 30, 2015

I could only see a connection issue in the error log. Is there anything I should do?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Oct 15, 2015

-1
superseded by #11828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants