Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more cmsStage etc. scripts #11828

Merged
merged 14 commits into from
Oct 20, 2015
Merged

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Oct 15, 2015

https://hypernews.cern.ch/HyperNews/CMS/get/tif-alignment/465.html
Also rebased on #11195 which would have generated a merge conflict

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_6_X.

No more cmsStage etc. scripts

It involves the following packages:

Alignment/OfflineValidation
MuonAnalysis/MomentumScaleCalibration

@diguida, @cerminar, @monttj, @cmsbuild, @franzoni, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @frmeier, @argiro, @bellan, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Oct 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8925/console

@cmsbuild
Copy link
Contributor



########### DATABASE conditions ############################
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_condDBv2_cff")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hroskes in 76X and 75X V2 is default, in 74X you should keep the additional part in the name.

@cmsbuild
Copy link
Contributor

Pull request #11828 was updated. @diguida, @cerminar, @monttj, @cmsbuild, @franzoni, @vadler, @mmusich can you please check and sign again.

@hroskes
Copy link
Contributor Author

hroskes commented Oct 15, 2015

After consulting with Ulascan I removed the large .ini file, I just left one example so people have something to copy the syntax.
@diguida @usarica does this look ok to you?

@usarica
Copy link
Contributor

usarica commented Oct 15, 2015

It looks fine to me. The reason why I kept that file was to provide an example of what options can be used to run the Zmumu validation tool. testValidate.ini works equally well to keep the exemplary configuration.

@diguida
Copy link
Contributor

diguida commented Oct 16, 2015

please test
Comments addressed, thanks. Please back-port them to 75X and 74X PR, too (in the latter, do not modify the conddb version).
Concerning the "legacy" ini file for ZMuMu: I suggest to keep track on this in the alignment repository.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8942/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Oct 16, 2015

+1

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Oct 20, 2015
@davidlange6 davidlange6 merged commit d3ba289 into cms-sw:CMSSW_7_6_X Oct 20, 2015
@hroskes hroskes deleted the no-cmsStage-76X branch October 20, 2015 14:24
davidlange6 added a commit that referenced this pull request Nov 4, 2015
Backport of #11828: No more cmsStage etc. scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants