Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr90x L1T Stage2 for Phase2 #17248

Merged
merged 10 commits into from Jan 31, 2017
Merged

Pr90x L1T Stage2 for Phase2 #17248

merged 10 commits into from Jan 31, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jan 23, 2017 •
edited

PR 90x for change in configuration to use L1T Stage2 (as opposed to L1T Legacy) in Phase2 era.
This PR also includes (needed to pass tests) #17260 which fixed crashes in HCAL TPs for Phase2

This PR is needed for Phase2 MC Production.

Details:

  • Use phase2_common era modifier to
    • switch in L1T configuration to use Stage2
    • configure conditions of L1T Muon, Calorimeter, and Global (as in Stage2)
    • configure L1T RAW2DIGI and DIGI2RAW to use Stage2 products
  • Include back in simHcalTrigPrimitiveDigis and simHcalTTPDigis into hcalDigiSequence

@rekovic
Copy link
Contributor Author

rekovic commented Jan 23, 2017

please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Jan 23, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17379/console Started: 2017/01/23 11:53

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_9_0_X.

It involves the following packages:

L1Trigger/L1TCalorimeter
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TNtuples

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

-1

Tested at: 1b5a8a4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17248/17379/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-22-2300/src/L1Trigger/L1TNtuples/plugins/L1TauRecoTreeProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-22-2300/src/L1Trigger/L1TNtuples/plugins/L1Muon2RecoTreeProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-22-2300/src/L1Trigger/L1TNtuples/plugins/L1MetFilterRecoTreeProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-22-2300/src/L1Trigger/L1TNtuples/plugins/L1ExtraTreeProducer.cc 
/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-01-22-2300/external/slc6_amd64_gcc530/lib/libCore.so: error adding symbols: File in wrong format
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc6_amd64_gcc530/src/L1Trigger/L1TCalorimeter/src/L1TriggerL1TCalorimeter/libL1TriggerL1TCalorimeter.so] Error 1
Leaving library rule at L1Trigger/L1TCalorimeter
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-22-2300/src/L1Trigger/L1TNtuples/plugins/L1ElectronRecoTreeProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-22-2300/src/L1Trigger/L1TNtuples/plugins/L1UpgradeTreeProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-01-22-2300/src/L1Trigger/L1TNtuples/plugins/L1uGTTreeProducer.cc

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Pull request #17248 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #17248 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic rekovic mentioned this pull request Jan 24, 2017
Open
@matz-e
Increase robustness of HCAL TP LUT generation.
5206199 
The current code crashes for Phase2.  Instead of generating all possible
DetIds and testing which ones are allowed, it is a lot cleaner to just
iterate over the produced metadata ids.
@rekovic
Copy link
Contributor Author

rekovic commented Jan 28, 2017

ping @franzoni, @arunhep, @cerminar
Please review and sign/comment.

@franzoni
Copy link

hello @rekovic

do you understand the changes in LocalTrigger of DT's , in the 2023 workflows of the matrix ?
see for instance https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_0_X_2017-01-25-1100+17248/18001/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7/DT_03-LocalTrigger-TM.html

all the 2023 are affected by that.

@franzoni
Copy link

+1

signing for AlCa since the only file you've modified which is under our signature
only changes the logic behind the HCAL trigger primitives
and I can't imagine (a simple explanation ) for that to be the reason of the DT local trigger change
( see my previous post )

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@rekovic
Copy link
Contributor Author

rekovic commented Jan 30, 2017

Thanks @franzoni
Compared to Legacy, the Stage2 trigger has all new muon track finders.
However, none of DT or DT TP code was changed, so I am not sure about these plots.

@davidlange6
Copy link
Contributor

+1
(but @rekovic - you need to migrate away from is chosens..)

@cmsbuild cmsbuild merged commit af4debe into cms-sw:CMSSW_9_0_X Jan 31, 2017
@davidlange6
Copy link
Contributor

Hi @rekovic - I notice belatedly that this looks to have broken some relval tests. Can you have a look

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_9_0_X_2017-02-01-2300/pyRelValMatrixLogs/run/21253.0_QCD_Pt_600_800_14+QCD_Pt_600_800_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step2_QCD_Pt_600_800_14+QCD_Pt_600_800_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log

@davidlange6 davidlange6 mentioned this pull request Feb 2, 2017
Closed
@rekovic
Copy link
Contributor Author

rekovic commented Feb 2, 2017

@davidlange6, @matz-e The exceptions seem to be due to HcalTrigPrimDigiProducer and the LUTs used.

   [3] Calling method for module HcalTrigPrimDigiProducer/'simHcalTriggerPrimitiveDigis'
Exception Message:
LUT has 1024 entries for 1661 but 1186 was requested.
----- End Fatal Exception -------------------------------------------------

@davidlange6
Copy link
Contributor

davidlange6 commented Feb 2, 2017 via email

@rekovic
Copy link
Contributor Author

rekovic commented Feb 2, 2017

simHcalTriggerPrimitiveDigis were not executed prior to 17248.

@davidlange6
Copy link
Contributor

davidlange6 commented Feb 2, 2017 via email

@matz-e
Copy link
Contributor

matz-e commented Feb 2, 2017

I'll look into it.

@rekovic
Copy link
Contributor Author

rekovic commented Feb 2, 2017

ok

@matz-e
Copy link
Contributor

matz-e commented Feb 2, 2017

So… HCAL has not yet defined any trigger modes beyond 2017, and this is tripping this crash. I'll work on a solution.

@davidlange6
Copy link
Contributor

and as an added bonus, this PR generates a bunch of errors that we need a fix for

!@#$ Converted hit with station 1, CSC_ID 1, sector index 6, subsector 2, wire 5, strip 213, BX 0, neighbor 0 has no match
!@#$ Option 1 with endcap 1, station 1, CSC_ID 1, ring 4, chamber 24, wire 4, strip 28, BX 0, neighbor 0
!@#$ Option 2 with endcap 1, station 1, CSC_ID 1, ring 4, chamber 24, wire 4, strip 31, BX 0, neighbor 0
!@#$ Option 3 with endcap 1, station 1, CSC_ID 2, ring 1, chamber 19, wire 23, strip 22, BX 0, neighbor 0
!@#$ Option 4 with endcap 1, station 1, CSC_ID 4, ring 2, chamber 18, wire 44, strip 122, BX 0, neighbor 0
!@#$ Option 5 with endcap 1, station 2, CSC_ID 3, ring 1, chamber 10, wire 53, strip 10, BX 0, neighbor 0
!@#$ Option 6 with endcap 1, station 2, CSC_ID 3, ring 1, chamber 10, wire 53, strip 10, BX 0, neighbor 1
!@#$ Option 7 with endcap 1, station 2, CSC_ID 2, ring 1, chamber 12, wire 12, strip 102, BX 0, neighbor 0
!@#$ Option 8 with endcap 1, station 2, CSC_ID 7, ring 2, chamber 6, wire 48, strip 147, BX 0, neighbor 0
!@#$ Option 9 with endcap 1, station 2, CSC_ID 7, ring 2, chamber 12, wire 13, strip 24, BX 0, neighbor 0
!@#$ Option 10 with endcap 1, station 2, CSC_ID 7, ring 2, chamber 18, wire 20, strip 128, BX 0, neighbor 0
!@#$ Option 11 with endcap 1, station 3, CSC_ID 3, ring 1, chamber 10, wire 59, strip 148, BX 0, neighbor 0

@davidlange6 davidlange6 mentioned this pull request Feb 2, 2017
Merged
@rekovic
Copy link
Contributor Author

rekovic commented Feb 7, 2017

@davidlange6 Which test workflow produced the above cout ?

@rekovic rekovic mentioned this pull request Feb 8, 2017
Closed
This was referenced Feb 21, 2017
Closed
Closed
@rekovic rekovic mentioned this pull request Mar 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed l1-approved orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rekovic @cmsbuild @civanch @franzoni @davidlange6 @matz-e