Step 3: Simulation Clang tidy code-checks-all

[ianna]

• Split Test for Simulation Packages Clang checks-all #20511 as suggested by @civanch here Test for Simulation Packages Clang checks-all #20511 (comment)

Step 3. SimGeneral

• This PR is based on Step 2 amendment: Simulation Clang tidy code-checks-all and Clang Warnings Removed #20527, Step 2: Simulation Clang tidy code-checks-all #20525, Step 1 amendment: Simulation Clang tidy code-checks-all and Clang Warnings Removed #20524, Step 1: Simulation Clang tidy code-checks-all #20514
  It will be rebased if needed after they are subsequently merged.

@civanch - FYI

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20528/715

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22994/console Started: 2017/09/15 10:13

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/CherenkovAnalysis
SimG4CMS/EcalTestBeam
SimG4CMS/FP420
SimG4CMS/Forward
SimG4CMS/HGCalTestBeam
SimG4CMS/HcalTestBeam
SimG4CMS/Muon
SimG4CMS/ShowerLibraryProducer
SimG4CMS/Tracker
SimG4Core/Application
SimG4Core/CheckSecondary
SimG4Core/CountProcesses
SimG4Core/CustomPhysics
SimG4Core/GFlash
SimG4Core/Generators
SimG4Core/Geometry
SimG4Core/GeometryProducer
SimG4Core/HelpfulWatchers
SimG4Core/KillSecondaries
SimG4Core/MagneticField
SimG4Core/Notification
SimG4Core/Physics
SimG4Core/PhysicsLists
SimG4Core/PrintGeomInfo
SimG4Core/PrintTrackNumber
SimG4Core/SaveSimTrackAction
SimG4Core/SensitiveDetector
SimG4Core/TrackingVerbose
SimG4Core/Watcher
SimGeneral/CaloAnalysis
SimGeneral/DataMixingModule
SimGeneral/GFlash
SimGeneral/HepPDTESSource
SimGeneral/HepPDTRecord
SimGeneral/MixingModule
SimGeneral/NoiseGenerators
SimGeneral/PileupInformation
SimGeneral/TrackingAnalysis
SimRomanPot/SimFP420

@cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks.
@namapane, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @argiro, @calderona, @HuguesBrun, @rovere, @ebrondol, @VinInn, @trocino, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[ianna]

hold

[cmsbuild]

Pull request has been put on hold by @ianna
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

+1
Tested at: 30bc0fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20528/22994/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9f20abe
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20528/22994/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20528/22994/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20528/22994/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2646869
• DQMHistoTests: Total failures: 214
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2646466
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[ianna]

unhold

[ianna]

@civanch - there are no conflicts after step 2 is merged, this PR can also go in an IB

[civanch]

+1

[ianna]

@davidlange6 - would you like me to retrigger tests?

[civanch]

@ianna , if you restart test, may be rebase is useful, I agree that there is no conflicts and this may not be needed.