Move Data ReReco ZeroBias RelvVals to use @rerecoZeroBias DQM sequence #27415

mmusich · 2019-06-30T16:46:41Z

PR description:

As discussed in this JIRA ticket https://its.cern.ch/jira/browse/PDMVRELVALS-50 we (Tracker DPG) would like to have the ZeroBias Run2 Data Relvals produced using a DQM sequence containing @commonSiStripZeroBias, see:

cmssw/DQMOffline/Configuration/python/autoDQM.py

Line 5 in 56a9801

'commonSiStripZeroBias': ['DQMOfflineCommonSiStripZeroBias',

in lieu of @standardDQMsee:

cmssw/DQMOffline/Configuration/python/autoDQM.py

Line 103 in 56a9801

'standardDQM': ['DQMOffline',

for the ZeroBias PD as it currently it is in the relval matrix.
This would allow to test the sequence that is actually run at Tier-0 during physics production certification and spot beforehand possible issues affecting production, as it recently happened e.g. for the issues leading to PR: #27246.
The DQM and PdmV teams have suggested to use the sequence @rerecoZeroBias defined at

cmssw/DQMOffline/Configuration/python/autoDQM.py

Line 87 in 56a9801

    
           'rerecoZeroBias' : ['@commonSiStripZeroBias+@muon+@hcal+@jetmet+@ecal+@egamma+@L1TMuon+@L1TEgamma',

(introduced in this commit 3390211) which is supposed to be used also during the UltraLegacy Run3 data re-reco

PR validation:

Standard tests with runTheMatrix for the touched workflows pass:

runTheMatrix.py -l 134.710,134.812,134.912,136.732,136.745,136.756,136.767,136.778,136.789,136.801,136.813,136.825,136.837,136.856,136.868,136.880,136.892 -t 4 -j 8 --ibeos

though I had to refrain to use @rerecoZeroBias for the following worflows 134.710,134.812,134.912,136.732,136.745,136.756,136.767,136.778 because using this sequence they would break, as harvesting step fails with:

----- Begin Fatal Exception 27-Jun-2019 11:22:17 CEST-----------------------
An exception of category 'StdException' occurred while
[0] Processing global end LuminosityBlock run: 251251 luminosityBlock: 139
[1] Calling method for module SiPixelCertification/'sipixelCertification'
Exception Message:
A std::exception was thrown.
DQM object not found: Pixel/EventInfo/reportSummary
----- End Fatal Exception -------------------------------------------------

interestingly for the phase-0 pixel geometry (2015,2016).
@fioriNTU @schneiml @jfernan2 FYI, as this might have implications for the UL 2016 re-reco.

if this PR is a backport please specify the original PR:

This PR is not a backport

cc:
@jandrea @arossi83

…@commonSiStripZeroBias

cmsbuild · 2019-06-30T16:47:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-30T16:54:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27415/10711

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Add bx skim and corresponding RelVal #26476, Adding Run 330098 (2019 MWGR3) in data relvals #27341
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add bx skim and corresponding RelVal #26476, Adding Run 330098 (2019 MWGR3) in data relvals #27341, Closeby Workflows with TICL Variations in runTheMatrix #27392

cmsbuild · 2019-06-30T16:55:17Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2019-07-02T12:30:56Z

please test workflow 136.789,136.801,136.813,136.825,136.837,136.856,136.868,136.880,136.892

cmsbuild · 2019-07-02T12:31:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1292/console Started: 2019/07/02 14:33

cmsbuild · 2019-07-02T14:28:59Z

+1
Tested at: d6b79cb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afe75f/1292/summary.html

cmsbuild · 2019-07-02T14:29:03Z

Comparison job queued.

schneiml · 2019-07-02T15:26:38Z

Two comments:

What will be used for the (UL) rereco is not decided by the code here, but by what we (DQM) tell PdmV to run. The request from Tracker side to use @commonSiStripZeroBias (via @rerecoZeroBias) is well known and should be respected no matter what happens to this PR.
This PR however does significantly improve our PR tests, by moving them closer to what will run in production (we used @commonSiStripZeroBias in Prompt since a long time and we will be using it for rerecos in the future).

cmsbuild · 2019-07-02T16:19:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afe75f/1292/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.789_RunZeroBias2017B+RunZeroBias2017B+HLTDR2_2017+RECODR2_2017reHLT_ZBPrompt+HARVEST2017ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.801_RunZeroBias2017C+RunZeroBias2017C+HLTDR2_2017+RECODR2_2017reHLT_ZBPrompt+HARVEST2017ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.813_RunZeroBias2017D+RunZeroBias2017D+HLTDR2_2017+RECODR2_2017reHLT_ZBPrompt+HARVEST2017ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.825_RunZeroBias2017E+RunZeroBias2017E+HLTDR2_2017+RECODR2_2017reHLT_ZBPrompt+HARVEST2017ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.837_RunZeroBias2017F+RunZeroBias2017F+HLTDR2_2017+RECODR2_2017reHLT_ZBPrompt+HARVEST2017ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.856_RunZeroBias2018A+RunZeroBias2018A+HLTDR2_2018+RECODR2_2018reHLT_ZBOffline+HARVEST2018ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.868_RunZeroBias2018B+RunZeroBias2018B+HLTDR2_2018+RECODR2_2018reHLT_ZBOffline+HARVEST2018ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.88_RunZeroBias2018C+RunZeroBias2018C+HLTDR2_2018+RECODR2_2018reHLT_ZBOffline+HARVEST2018ZB
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-afe75f/136.892_RunZeroBias2018D+RunZeroBias2018D+HLTDR2_2018+RECODR2_2018reHLT_ZBPrompt+HARVEST2018_PromptZB

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3290686
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3290350
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

fabiocos · 2019-07-08T06:20:27Z

@prebello @zhenhu @kpedro88 could you please have a look at this? @jfernan2 this is involving DQM sequences

fabiocos · 2019-07-08T06:51:08Z

There is no conflict with #27449 in case that is merged (as we would like to do quickly)

kpedro88 · 2019-07-08T14:39:27Z

+upgrade

prebello · 2019-07-09T12:38:55Z

+1

cmsbuild · 2019-07-09T12:39:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-07-09T19:25:34Z

+1

chayanit · 2019-08-09T06:31:13Z

@mmusich , we have received report from PPS validator in 11_0_0_pre4 campaign recently. They complained about missing DQM plots in ZeroBias relvals and seems to be caused by this PR. Have you noticed about this?
Cheers,
Chayanit

mmusich · 2019-08-09T07:02:14Z

@chayanit. This PR has been taylored for the needs of Tracker / Tracking, and indeed has fared perfectly fine for the purposes of Tracker / Tracking. You can check that in our validation reports that are all OK for 11_0_0_pre4 (see https://cms-pdmv.cern.ch/valdb/?srch=11_0_0_pre4&Reconstruction=true&RData=true).
As for other DPGs, it's a pity that PdmV did not advertise the ticket where this PR was discussed: https://its.cern.ch/jira/browse/PDMVRELVALS-50 as I explicitly requested.
Can you clarify why this did not happen?
By the way: the PPS addition to the sequence has been done in this commit 835a4af#diff-cbd7e70fcf453b18b0264833a02bcee8. It seems it did not enter in 11_0_0_pre4, but will be there in 11_0_0_pre5.

chayanit · 2019-08-09T07:25:27Z

@mmusich clearly, this thing happened before I started so I can't answer why the advertise did not happen. I'm just trying to dig out what was happened and I think everything is clear now. I will inform PPS validators that everything should be fine in next releases. Thanks.

mmusich · 2019-08-09T07:35:37Z

@chayanit

I will inform PPS validators that everything should be fine in next releases.

Actually I don't think it will fine either in 11_0_0_pre5 because the @ctpps tag needs to be added to rerecoZeroBiasFakeHLT as that is the sequence which is run on 2017 and 2018 after this PR #27467 has been merged.
I can fix it in the PR I have open on these file #27727 (after I test it runs fine).

mmusich added 2 commits June 21, 2019 17:55

change the DQM sequence run for Run2 ZeroBias datasets in relvals to …

55fe609

…@commonSiStripZeroBias

move (where possible) @commonSiStripZeroBias to @rerecoZeroBias

d6b79cb

cmsbuild added this to the CMSSW_11_0_X milestone Jun 30, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jun 30, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 30, 2019

cmsbuild added tests-started and removed tests-pending labels Jul 2, 2019

cmsbuild added tests-approved and removed tests-started labels Jul 2, 2019

cmsbuild mentioned this pull request Jul 2, 2019

Adding Run 330098 (2019 MWGR3) in data relvals #27341

Merged

cmsbuild added comparison-available and removed comparison-pending labels Jul 2, 2019

This was referenced Jul 3, 2019

Add workflows for 2023 and 2024. Replace 13TeV 2021 by 14TeV. #27433

Merged

Clean up Phase2 workflows #27449

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 8, 2019

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels Jul 9, 2019

cmsbuild mentioned this pull request Jul 9, 2019

First attempt to remove DQM HLT warnings from logs caused by HLT Fake menus #27467

Merged

cmsbuild added orp-approved and removed orp-pending labels Jul 9, 2019

cmsbuild merged commit 0280165 into cms-sw:master Jul 9, 2019

jfernan2 added a commit to jfernan2/cmssw that referenced this pull request Jul 10, 2019

Rebase to PR cms-sw#27415

f8cc197

mmusich mentioned this pull request Aug 8, 2019

Move 2015/2016 Data ReReco ZeroBias RelVals to use @rerecoZeroBias DQM sequence #27727

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Data ReReco ZeroBias RelvVals to use @rerecoZeroBias DQM sequence #27415

Move Data ReReco ZeroBias RelvVals to use @rerecoZeroBias DQM sequence #27415

mmusich commented Jun 30, 2019

cmsbuild commented Jun 30, 2019

cmsbuild commented Jun 30, 2019

cmsbuild commented Jun 30, 2019

fabiocos commented Jul 2, 2019

cmsbuild commented Jul 2, 2019 •

edited

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

schneiml commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

fabiocos commented Jul 8, 2019

fabiocos commented Jul 8, 2019

kpedro88 commented Jul 8, 2019

prebello commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

fabiocos commented Jul 9, 2019

chayanit commented Aug 9, 2019

mmusich commented Aug 9, 2019

chayanit commented Aug 9, 2019

mmusich commented Aug 9, 2019

Move Data ReReco ZeroBias RelvVals to use @rerecoZeroBias DQM sequence #27415

Move Data ReReco ZeroBias RelvVals to use @rerecoZeroBias DQM sequence #27415

Conversation

mmusich commented Jun 30, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jun 30, 2019

cmsbuild commented Jun 30, 2019

cmsbuild commented Jun 30, 2019

fabiocos commented Jul 2, 2019

cmsbuild commented Jul 2, 2019 • edited

cmsbuild commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

schneiml commented Jul 2, 2019

cmsbuild commented Jul 2, 2019

fabiocos commented Jul 8, 2019

fabiocos commented Jul 8, 2019

kpedro88 commented Jul 8, 2019

prebello commented Jul 9, 2019

cmsbuild commented Jul 9, 2019

fabiocos commented Jul 9, 2019

chayanit commented Aug 9, 2019

mmusich commented Aug 9, 2019

chayanit commented Aug 9, 2019

mmusich commented Aug 9, 2019

cmsbuild commented Jul 2, 2019 •

edited