-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First attempt to remove DQM HLT warnings from logs caused by HLT Fake menus #27467
First attempt to remove DQM HLT warnings from logs caused by HLT Fake menus #27467
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27467/10795
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @andrius-k, @kmaeshima, @zhenhu, @schneiml, @prebello, @kpedro88, @pgunnell, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@fabiocos this PR is almost done. Still pending:
I can dedicate some time next week to the last three ones and include them here or in another PR as you prefer. |
@jfernan2 as said at the meeting, I believe that this PR as it is is already a good step forward, and fixes the part of the issues deriving from the change in the HLT menu. I would as to @prebello @zhenhu @kpedro88 to check it, and possibly merge it, adding further cleaning in a subsequent PR, which will probably need to address a different kind of issue. |
+upgrade |
+1 |
@jfernan2 do you agree to merge this PR as it is? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@jfernan2 failed to update the file
also to the newly created |
PR description:
This PR is a First attempt to remove DQM HLT warnings from logs caused by HLT Fake menus, flooding logs from RelVals not using GRun HLT menu (currently only Upgrade menus)
Basically I replaced every instance of @standardDQM+@ExtraHLT by @standardDQMFakeHLT in all Run1+Run2 relvals defined in Configuration/PyReleaseValidation/python/relval_steps.py
I left untouched "mother" steps definitions like *FullHEfail, HARVESTD or dataReco which may be used in the future as usual templates, and are in principle not used in current Relvals.
I am not sure if there exists a more clever way to do this.
I also removed a resilient HLT sequence in @standardDQMFakeHLT which was still causing messages in logs despite being warned a Fake HLT menu was being used.
This PR is connected to the recent change to Fake menus in 2018 Relvals #27331 and #21815
Besides issue #27372 should move PR tests to 2021 wf in CMSSW_11
if this PR is a backport please specify the original PR:
It is NOT a backport, though I am not sure if it needs a backport