Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the packedCandidate to gen associations in miniAOD_customizeAllData #34113

Merged
merged 1 commit into from Jun 16, 2021

Conversation

elusian
Copy link

@elusian elusian commented Jun 14, 2021

PR description:

#33774 added two new collections to the MINIAODSIM event content, and the corresponding task. However, if cmsDriver is provided both the MINIAODSIM event content and the --data switch, the prunedGenParticles collection that is used to produce the associations is removed by a customizer and the job crashes due to ProductNotFound.

This PR adds the two new collections to the list of collections to remove with the miniAOD_customizeAllData function, inside the coreTools.py file.

Closes #34112

PR validation:

The tests were performed using the scram b runtests inside TauAnalysis/MCEmbeddingTools, which first triggered the issue

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport

…s to remove when customizing cmsDriver to run on data
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34113/23305

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @elusian for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor

please test

@mrodozov
Copy link
Contributor

abort

@mrodozov
Copy link
Contributor

test parameters:
addpkg = TauAnalysis/MCEmbeddingTools

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-835132/15942/summary.html
COMMIT: f0c9001
CMSSW: CMSSW_12_0_X_2021-06-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34113/15942/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2862485
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor

the test is running fine with this

@slava77
Copy link
Contributor

slava77 commented Jun 15, 2021

+reconstruction

for #34113 f0c9001

  • code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences; the unit test in TauAnalysis/MCEmbeddingTools runs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 16, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Failure in 12_X IB from TauAnalysis/MCEmbeddingTools
5 participants