Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2018 fastsim workflow to the short matrix #35804

Merged
merged 1 commit into from Oct 24, 2021

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Oct 23, 2021

to provide a minimal coverage for phase-1 fastsim

@cms-sw/fastsim-l2 do we have a Run-3 fastsim workflow?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35804/26167

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Oct 23, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886c37/19866/summary.html
COMMIT: df8ae5a
CMSSW: CMSSW_12_1_X_2021-10-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35804/19866/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 23-Oct-2021 20:16:59 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step'
   [2] Prefetching for module MultiTrackValidator/'trackValidatorBuilding'
   [3] Prefetching for module TrackProducer/'detachedTripletStepTracks'
   [4] Prefetching for module TrackCandidateProducer/'detachedTripletStepTrackCandidates'
   [5] Prefetching for module FastTrackerRecHitMaskProducer/'detachedTripletStepMasks'
   [6] Prefetching for module TrackProducer/'detachedQuadStepTracks'
   [7] Prefetching for module TrackCandidateProducer/'detachedQuadStepTrackCandidates'
   [8] Prefetching for module FastTrackerRecHitMaskProducer/'detachedQuadStepMasks'
   [9] Prefetching for module TrackProducer/'lowPtTripletStepTracks'
   [10] Prefetching for module TrackCandidateProducer/'lowPtTripletStepTrackCandidates'
   [11] Prefetching for module FastTrackerRecHitMaskProducer/'lowPtTripletStepMasks'
   [12] Prefetching for module TrackProducer/'highPtTripletStepTracks'
   [13] Prefetching for module TrackCandidateProducer/'highPtTripletStepTrackCandidates'
   [14] Prefetching for module FastTrackerRecHitMaskProducer/'highPtTripletStepMasks'
   [15] Prefetching for module TrackProducer/'lowPtQuadStepTracks'
   [16] Prefetching for module TrackCandidateProducer/'lowPtQuadStepTrackCandidates'
   [17] Prefetching for module FastTrackerRecHitMaskProducer/'lowPtQuadStepMasks'
   [18] Calling method for module TrackTfClassifier/'initialStep'
Exception Message:
No "TfGraphRecord" record found in the EventSetup.

 The Record is delivered by an ESSource or ESProducer but there is no valid IOV for the synchronization value.
 Please check 
   a) if the synchronization value is reasonable and report to the hypernews if it is not.
   b) else check that all ESSources have been properly configured. 
----- End Fatal Exception -------------------------------------------------

@slava77
Copy link
Contributor Author

slava77 commented Oct 23, 2021

@cmsbuild please test with #35801

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886c37/19867/summary.html
COMMIT: df8ae5a
CMSSW: CMSSW_12_1_X_2021-10-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35804/19867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-886c37/2018.1_TTbar_13_UP18+TTbarFS_13_UP18+HARVESTUP18FS+MINIAODMCUP18FS

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2751113
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751091
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 170 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

A 2018 Fastsim wf is added to the short metrix.

@jordan-martins
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • The new workflow was needed, indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants