MonitorTrackResiduals: do not apply PV compatibility cut when running cosmics

[mmusich]

PR description:

I was casually looking at the Strip residuals in a CRAFT 2021 run but they don't make much sense e.g. the number of hits in TIB1 (https://tinyurl.com/yzwdcdc6) is less than BPIX1 (https://tinyurl.com/ygftohy4).
Also the Strip EndCap residuals plots are empty (https://tinyurl.com/ygxqol8b).
I strongly suspect this is due to the Primary Vertex compatibility cut at:

cmssw/DQM/TrackerMonitorTrack/src/MonitorTrackResiduals.cc

Line 251 in 6d2f660

return track.pt() > 0.75 && abs(track.dxy(primaryVertex.position())) < 5 * track.dxyError();

that makes no sense in cosmic data-taking and is severely limiting the phase-space from which the cosmic tracks are considered (https://tinyurl.com/yjzgap6c)
The correct behavior is implemented instead in the Pixel residuals code:

cmssw/DQM/SiPixelPhase1Track/plugins/SiPixelPhase1TrackResiduals.cc

Lines 80 to 82 in c6d0025

	return (!applyVertexCut_ ||
	(track.pt() > 0.75 && std::abs(track.dxy(vertices->at(0).position())) < 5 * track.dxyError()));
	},

in which the PV compatibility cut is put in OR with a switch that is set to false in cosmics (and indeed the pixel residuals in cosmic runs are filled).
This PR implements the same mechanism also for Strip residuals.

No regression is expected for collision runs (pp or HI).

PR validation:

I've run workflow 138.2 (from 2021 cosmics commissioning, Run 343498) with 1000 events:

runTheMatrix.py -l 138.2 -j 8 --command='-n 1000'

in the vanilla release and with the modifications of this branch and obtained:

CMSSW_12_1_X_2021-10-24-0000 as-is	CMSSW_12_1_X_2021-10-24-0000 + this PR

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but should probably be backported.

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35811/26172

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQM/SiStripMonitorClient (dqm)
• DQM/TrackerMonitorTrack (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[tvami]

urgent

• this should go into pre5 and the backport should go into the 12_0_4

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35f109/19876/summary.html
COMMIT: a3fdef3
CMSSW: CMSSW_12_1_X_2021-10-24-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35811/19876/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 57
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2751034
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

Hi @perrotta @qliphy can we merge this in today's IB? So if we cut a release tomorrow then the backport could still go in?

[perrotta]

+1