-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for TestDQMServicesDemo
unit test
#35921
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35921/26326
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with #35766 (abusing my testing rights to test this quickly; the other PR seems to be needed to avoid issues in unrelated wfs) |
type bugfix |
urgent |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c763d6/20118/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR tries to fix the DQM unit test
TestDQMServicesDemo
.It looks like some API calls in DQM-related scripts needed to be adjusted after the switch from
uproot-3
touproot-4
.See #35868 for some more details.
PR validation:
The relevant unit test now passes.
If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A