Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC DQM - Moving to DQMEDHarvesters #5869

Merged
merged 1 commit into from Oct 22, 2014

Conversation

acimmino
Copy link
Contributor

RPC clients have been migrated to the DQMEDHarvester interface as described in: https://twiki.cern.ch/twiki/bin/viewauth/CMS/ThreadedDQM.
Plus cleanups and bug fixes.

This PR supersedes my previous one (#5410)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @acimmino (Anna Cimmino) for CMSSW_7_3_X.

RPC DQM - Moving to DQMEDHarvesters

It involves the following packages:

DQM/RPCMonitorClient
DQM/RPCMonitorDigi

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Oct 17, 2014

many thanks @acimmino
waiting for the automatic tests before approving. it should work now.
cheers,
F.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Oct 17, 2014

+1
thanks @acimmino

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Oct 17, 2014

I'll wait until monday to approve this since I see there is still modules being removed.

davidlange6 added a commit that referenced this pull request Oct 22, 2014
RPC DQM - Moving to DQMEDHarvesters
@davidlange6 davidlange6 merged commit a0b0cba into cms-sw:CMSSW_7_3_X Oct 22, 2014


//General Client
#include <DQM/RPCMonitorClient/interface/RPCDqmClient.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Martin-Grunewald
Copy link
Contributor

Please add back in RPCDqmClient asap, it currently missing breaks lots of IB relvals!

@deguio
Copy link
Contributor

deguio commented Oct 27, 2014

this has been solved with #5987
F.

cmsbuild added a commit that referenced this pull request Jun 11, 2020
adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants