Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New set of RelVal GT with updated conditions for Run2 MC DIGI-RECO and new PF calibrations; fix of Hcal digis for fastsim; switching on CSV+SL tagger #7732

Merged
merged 14 commits into from Feb 14, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Feb 13, 2015

This is the final set of GT for next pre-release (originally in #7707):

  • Added Egamma PF Cluster corrections in all scenarios (so removed the ESPrefer in RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECAL_cfi.py);
  • Updated hadron PF calibrations for all scenarios;
  • Updated new conditions for Run2 MC DIGI-RECO campaign;
  • Removed unused records for old 3x3 APE in all the GT;
  • Removed unsupported SIM geometry scenarios;
  • Use the correct key for HI Run2 MC (as in Alca for hin  #7704).

In addition - current fastim configs miss the run2 setup for digitizers in fastsim. This PR takes care of that (will be more robust once we get eras working), originally in #7726

Finally, now that the new GT are made available, a new b-tagger can be switched on without crashing the reco sequence, this was also discussed in the merged #7542.
Note that the change in PhysicsTools/PatAlgos/python/producersLayer1/jetProducer_cfi.py will be crashing some of the PAT tests, because the new tagger is not yet included in the RelVals (a similar issue was discussed in #7678); originally in #7697

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_4_X.

Auto cond 740pre7 full changes

It involves the following packages:

Configuration/AlCa
Configuration/Applications
PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoParticleFlow/PFClusterProducer
SLHCUpgradeSimulations/Configuration

@civanch, @diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @franzoni, @nclopezo, @mdhildreth, @slava77, @vadler, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @rappoccio, @imarches, @ahinzmann, @acaudron, @TaiSakuma, @lgray, @Martin-Grunewald, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida diguida changed the title Auto cond 740pre7 full changes New set of RelVal GT with updated conditions for Run2 MC DIGI-RECO and new PF calibrations; fix of Hcal digis for fastsim; Switching on CSV+SL tagger Feb 13, 2015
@diguida diguida changed the title New set of RelVal GT with updated conditions for Run2 MC DIGI-RECO and new PF calibrations; fix of Hcal digis for fastsim; Switching on CSV+SL tagger New set of RelVal GT with updated conditions for Run2 MC DIGI-RECO and new PF calibrations; fix of Hcal digis for fastsim; switching on CSV+SL tagger Feb 13, 2015
@diguida
Copy link
Contributor Author

diguida commented Feb 13, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Feb 13, 2015

So, compared to what was already signed in #7697 + #7726 this has
only the following

DESRUN1_74_V3/DESRUN1_74_V4
    PFCalibrationRcd    -   PFCalibration_v0_mc PFCalibration_v1_mc
MCRUN1_74_V3/MCRUN1_74_V4
    as above
MCHI1_74_V3/MCHI1_74_V4
    as above
MCPA1_74_V3/MCPA1_74_V4
    as above
GR_R_74_V6A/GR_R_74_V8A
    PFCalibrationRcd    -   PFCalibration_v0_offline    PFCalibration_v1_mc
GR_R_74_V7A/GR_R_74_V9A
    PFCalibrationRcd    -   PFCalibration_v0_offline    PFCalibration_v1_mc

this is expected for MC .. and also, as I understand, for data as well.
I'll wait for jenkins results ... ugh
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7732/2594/summary.html ==> 404.

let's see what I get locally at least for the data

@diguida
Copy link
Contributor Author

diguida commented Feb 14, 2015

@slava77 That's correct. As the reconstruction is the same, the new PF hadron calibration is applied in all scenarios.
BTW, as promised you can see the full set of changes here

@slava77
Copy link
Contributor

slava77 commented Feb 14, 2015

Salvatore, thank you.
The twiki looks good.

@slava77
Copy link
Contributor

slava77 commented Feb 14, 2015

+1

for #7732 6f46b43
tested in CMSSW_7_4_X_2015-02-13-1400 (test area sign518b; comparing 74X+7726+7697 as a baseline with 74X+7732 as "new")

Changes appear in run1 workflows as expected.
The changes in run1 data are fairly similar to what is seen in MC (just to "confirm" the applicability of the mc PFCalibration payload)

Here are a few plots from 4.57 (ZEl skim from Run2012B)
the low-energy photon cut-off
all_sign518b-481-newvssign518b-481-ref_zelskim2012bwf4p57c_log10recopfcandidates_particleflow__rereco_obj_p42

the neutral hadron "regularization"
all_sign518b-481-newvssign518b-481-ref_zelskim2012bwf4p57c_log10recopfcandidates_particleflow__rereco_obj_p52

pfMet is OK
all_sign518b-481-newvssign518b-481-ref_zelskim2012bwf4p57c_log10recopfmets_pfmet__rereco_obj_pt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants