Dashboard: Revert LayoutItemContext #83465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
requested review from
drew08t,
axelavargas,
mdvictor,
Clarity-89 and
eledobleefe
and removed request for
a team
leeoniya
added
no-backport
grafana-pr-automation
bot
added
area/panel/timeseries
grafana-uiRemovalsLayoutItemContext/home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts LayoutItemContextLayoutItemContextProps /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts LayoutItemContextPropsLayoutItemContextProps.boostZIndex /home/runner/work/grafana/grafana/base/grafana-ui/dist/index.d.ts boostZIndex(): () => void; |
grafana-pr-automation
bot
added
the
levitate breaking change
grafana-pr-automation
bot
requested review from
a team and
Ukochka
and removed request for
a team
This was referenced Feb 27, 2024
baldm0mma
approved these changes
Feb 27, 2024
leeoniya
changed the title
mckn
reviewed
Feb 28, 2024
There was a problem hiding this comment.
LGTM! I like that we are removing things and making the API surface smaller 🙌🏻
I noticed that we use this in scenes. What it the replacement for LayoutItemContext? Do we have any or are they left on their own to figure this out? I guess that applies to potential external plugins as well.
torkelo
approved these changes
Mar 4, 2024
|
@leeoniya this requires some kind of revert of grafana/scenes#530 as well, do you mind picking this up? |
|
that pr has more changes in it that im not familiar with. was hoping you peeps could pick it up: grafana/scenes#622 also waiting in scenes update to land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've switched to using global portals in #81986, so this is no longer needed.
originally introduced in #80116