New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Revert descending z-index changes #83466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
requested review from
joshhunt,
ashharrison90,
bfmatei,
Sergej-Vlasov,
academo and
torkelo
and removed request for
a team
February 27, 2024 05:19
leeoniya
added
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
labels
Feb 27, 2024
torkelo
approved these changes
Mar 4, 2024
torkelo
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated DataTrail and DasboardControls to use navbarFixed instead
grafana-pr-automation
bot
added
the
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
label
Mar 4, 2024
grafana-pr-automation
bot
removed
the
levitate breaking change
A label indicating a breaking change and assigned by Levitate.
label
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dashboard
area/frontend
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this depends on #83465, and should follow it.
reverts:
it turned out to be too difficult to revert each PR in isolation due to conflicts. i did the first two successfully, but then employed a different strategy:
looking at the history of _dashboard_grid.scss, i restored it to the last commit before all of our z-index changes:
and then applied the only new changeset for reduced-motion:
still to be fixed:
zIndex.activePanel
has been used in recent work, so we need to figure out what to do in those two cases, and how to update them.grafana/public/app/features/trails/DataTrail.tsx
Line 247 in 2540842
grafana/public/app/features/dashboard-scene/scene/DashboardControls.tsx
Line 77 in 2540842
cc @torkelo ^^