Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Revert descending z-index changes #83466

Merged
merged 13 commits into from Mar 6, 2024

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Feb 27, 2024

this depends on #83465, and should follow it.

reverts:

it turned out to be too difficult to revert each PR in isolation due to conflicts. i did the first two successfully, but then employed a different strategy:

looking at the history of _dashboard_grid.scss, i restored it to the last commit before all of our z-index changes:

image

and then applied the only new changeset for reduced-motion:

image

still to be fixed:

  • it looks like zIndex.activePanel has been used in recent work, so we need to figure out what to do in those two cases, and how to update them.

zIndex: theme.zIndex.activePanel + 1,

cc @torkelo ^^

@leeoniya leeoniya marked this pull request as ready for review February 27, 2024 05:19
@leeoniya leeoniya requested review from a team as code owners February 27, 2024 05:19
@leeoniya leeoniya requested review from joshhunt, ashharrison90, bfmatei, Sergej-Vlasov, academo and torkelo and removed request for a team February 27, 2024 05:19
@leeoniya leeoniya added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Feb 27, 2024
@leeoniya leeoniya added this to the 11.0.x milestone Feb 27, 2024
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated DataTrail and DasboardControls to use navbarFixed instead

packages/grafana-data/src/themes/zIndex.ts Outdated Show resolved Hide resolved
Base automatically changed from leeoniya/revert-LayoutItemContext to main March 4, 2024 14:47
@grafana-pr-automation grafana-pr-automation bot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Mar 4, 2024
@grafana-pr-automation grafana-pr-automation bot requested a review from a team March 4, 2024 14:56
@leeoniya leeoniya enabled auto-merge (squash) March 6, 2024 14:07
@grafana-pr-automation grafana-pr-automation bot removed the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Mar 6, 2024
@grafana-pr-automation grafana-pr-automation bot removed the request for review from a team March 6, 2024 14:10
@leeoniya leeoniya merged commit 1dc6014 into main Mar 6, 2024
19 checks passed
@leeoniya leeoniya deleted the leeoniya/revert-descending-zindex branch March 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants