Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) inspect other dependencies versions #3352

Conversation

bartsmykla
Copy link
Contributor

Summary

Add option to display other dependencies (like coredns for example)
versions in GUI and kumactl.

kumactl inspect dataplanes will now contain additional cell with
other dependencies versions, currently with coredns version inside

Full changelog

no changelog

Issues resolved

no issue resolved

Documentation

no documentation change

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Add option to display other dependencies (like coredns for example)
versions in GUI and kumactl.

`kumactl inspect dataplanes` will now contain additional cell with
other dependencies versions, currently with coredns version inside

Signed-off-by: Bart Smykla <bartek@smykla.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #3352 (93456e0) into master (9a7dc1e) will decrease coverage by 0.02%.
The diff coverage is 62.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3352      +/-   ##
==========================================
- Coverage   52.25%   52.22%   -0.03%     
==========================================
  Files         929      929              
  Lines       54421    54452      +31     
==========================================
+ Hits        28437    28438       +1     
- Misses      23758    23789      +31     
+ Partials     2226     2225       -1     
Impacted Files Coverage Δ
pkg/core/xds/metadata.go 59.49% <0.00%> (-3.18%) ⬇️
app/kuma-dp/cmd/run.go 70.58% <50.00%> (-0.56%) ⬇️
app/kuma-dp/pkg/dataplane/dnsserver/dnsserver.go 71.11% <64.28%> (-0.32%) ⬇️
api/mesh/v1alpha1/dataplane_insight.pb.go 43.81% <80.00%> (+0.32%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 82.60% <100.00%> (+0.15%) ⬆️
app/kumactl/cmd/inspect/inspect_dataplanes.go 94.73% <100.00%> (+0.56%) ⬆️
pkg/xds/bootstrap/template_v3.go 99.13% <100.00%> (+<0.01%) ⬆️
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7dc1e...93456e0. Read the comment docs.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla enabled auto-merge (squash) November 25, 2021 06:02
@bartsmykla bartsmykla merged commit 4da705a into kumahq:master Nov 25, 2021
mergify bot pushed a commit that referenced this pull request Nov 25, 2021
* feat(*) inspect other dependencies versions

Add option to display other dependencies (like coredns for example)
versions in GUI and kumactl.

`kumactl inspect dataplanes` will now contain additional cell with
other dependencies versions, currently with coredns version inside

Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit 4da705a)
mergify bot added a commit that referenced this pull request Nov 25, 2021
* feat(*) inspect other dependencies versions

Add option to display other dependencies (like coredns for example)
versions in GUI and kumactl.

`kumactl inspect dataplanes` will now contain additional cell with
other dependencies versions, currently with coredns version inside

Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit 4da705a)

Co-authored-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla deleted the feat/add-other-dependencies-versions-to-dp-inspect branch November 25, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants