Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2283 make language agnostic subject and audit for projects after crud-master-py #2277

Merged
merged 15 commits into from
Dec 4, 2023
Merged

CON-2283 make language agnostic subject and audit for projects after crud-master-py #2277

merged 15 commits into from
Dec 4, 2023

Conversation

nprimo
Copy link
Contributor

@nprimo nprimo commented Nov 6, 2023

The suggestion made here have been added already (for play-with-containers project related audit/subject)

@nprimo nprimo requested a review from MSilva95 November 6, 2023 16:16
@nprimo nprimo self-assigned this Nov 6, 2023
@nprimo nprimo mentioned this pull request Nov 6, 2023
Closed
@nprimo
feat(devops-projects): add bonus question
1e77cb0 
- Add bonus question about using the student own solution instead
  of the provided one
MSilva95
MSilva95 requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall its ok, only some typos and suggestions
Don't forget the TODOS in the readmes as well
Sorry for some of the repetition but it was to mark the spots.

subjects/devops/cloud-design/README.md Outdated Show resolved Hide resolved
subjects/devops/cloud-design/README.md Outdated Show resolved Hide resolved
subjects/devops/cloud-design/README.md Outdated Show resolved Hide resolved
subjects/devops/code-keeper/README.md Outdated Show resolved Hide resolved
subjects/devops/orchestrator/README.md Outdated Show resolved Hide resolved
subjects/devops/play-with-containers/audit/README.md Show resolved Hide resolved
subjects/devops/play-with-containers/audit/README.md Show resolved Hide resolved
subjects/devops/play-with-containers/audit/README.md Show resolved Hide resolved
subjects/devops/play-with-containers/audit/README.md Show resolved Hide resolved
subjects/devops/play-with-containers/audit/README.md Show resolved Hide resolved
@nprimo
Copy link
Contributor Author

nprimo commented Nov 13, 2023

I run prettier on the repo for the devops projects subjects and audits in the last commit to ease checking the differences per commit :)

@nprimo nprimo requested a review from MSilva95 November 13, 2023 10:49
zamazzal
zamazzal approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@zamazzal zamazzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, expect the requested changes by Miguel.
But please try to make short PRs, so They can be reviewed easily.

MSilva95
MSilva95 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MSilva95 MSilva95 merged commit e0d5c1a into master Dec 4, 2023
2 checks passed
@MSilva95 MSilva95 deleted the CON-2283-make-language-agnostic-subject-and-audit-for-projects-after-crud-master-py branch December 4, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSilva95 MSilva95 MSilva95 approved these changes

@zamazzal zamazzal zamazzal approved these changes

Assignees

@nprimo nprimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nprimo @zamazzal @MSilva95