-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-#### Fix of ai.go js tests to match updated subjects #2750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a small comment on listed, but it's just a personal opinion
6782562
to
8c4315f
Compare
@Oumaimafisaoui lgtm after check with runner
|
8c4315f
to
5ca7ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me as I am the one proposing most of those changes.
And it s good if it was tried thru the runner as per last comment of Louis. Seems to be tested correctly from my point of view.
Why?
After the miscine was tested as a student, two tests had some inconsistencies with updated subjects.
Solution Overview
Fixes of inconsistencies to match two updated subjects.