-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: teach alternation update-assignment operator (//=
)
#142
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
759ae5e
fix(jaq-syn): explicitly declare MSRV
bb010g a9f8b7a
style: normalize assignment operator sorting
bb010g 9c09972
docs: consistify filter & operator documentation
bb010g cd8f76c
test: refactor (update-)assignment operator tests
bb010g 3c5b6fa
feat: teach alternation update-assignment operator
bb010g 362b7b1
[WIP] feat: unstable-flag feature
bb010g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,57 @@ | ||
use serde_json::Value; | ||
|
||
fn yields(x: jaq_interpret::Val, f: &str, ys: impl Iterator<Item = jaq_interpret::ValR>) { | ||
#[cfg(not(feature = "unstable-flag"))] | ||
pub const UNSTABLE: bool = false; | ||
#[cfg(feature = "unstable-flag")] | ||
pub const UNSTABLE: bool = false; | ||
|
||
#[track_caller] | ||
fn yields( | ||
#[cfg_attr(not(feature = "unstable-flag"), allow(unused_variables))] unstable: bool, | ||
x: jaq_interpret::Val, | ||
f: &str, | ||
ys: impl Iterator<Item = jaq_interpret::ValR>, | ||
) { | ||
let mut ctx = jaq_interpret::ParseCtx::new(Vec::new()); | ||
ctx.insert_natives(jaq_core::core()); | ||
ctx.insert_natives(jaq_core::core( | ||
#[cfg(feature = "unstable-flag")] | ||
unstable, | ||
)); | ||
|
||
let (f, errs) = jaq_parse::parse(f, jaq_parse::main()); | ||
let (f, errs) = jaq_parse::parse( | ||
#[cfg(feature = "unstable-flag")] | ||
unstable, | ||
f, | ||
jaq_parse::main( | ||
#[cfg(feature = "unstable-flag")] | ||
unstable, | ||
), | ||
); | ||
assert!(errs.is_empty()); | ||
ctx.yields(x, f.unwrap(), ys) | ||
} | ||
|
||
pub fn fail(x: Value, f: &str, err: jaq_interpret::Error) { | ||
yields(x.into(), f, core::iter::once(Err(err))) | ||
#[track_caller] | ||
pub fn fail(unstable: bool, x: Value, f: &str, err: jaq_interpret::Error) { | ||
yields(unstable, x.into(), f, core::iter::once(Err(err))) | ||
} | ||
|
||
pub fn give(x: Value, f: &str, y: Value) { | ||
yields(x.into(), f, core::iter::once(Ok(y.into()))) | ||
#[track_caller] | ||
pub fn give(unstable: bool, x: Value, f: &str, y: Value) { | ||
yields(unstable, x.into(), f, core::iter::once(Ok(y.into()))) | ||
} | ||
|
||
pub fn gives<const N: usize>(x: Value, f: &str, ys: [Value; N]) { | ||
yields(x.into(), f, ys.into_iter().map(|y| Ok(y.into()))) | ||
#[track_caller] | ||
pub fn gives<const N: usize>(unstable: bool, x: Value, f: &str, ys: [Value; N]) { | ||
yields(unstable, x.into(), f, ys.into_iter().map(|y| Ok(y.into()))) | ||
} | ||
|
||
#[macro_export] | ||
macro_rules! yields { | ||
($func_name:ident, $filter:expr, $output: expr) => { | ||
($func_name:ident, $unstable:expr, $filter:expr, $output: expr) => { | ||
#[test] | ||
fn $func_name() { | ||
give(json!(null), $filter, json!($output)) | ||
give($unstable, json!(null), $filter, json!($output)) | ||
} | ||
}; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed, because
jaq-core
depends onjaq-interpret
, which depends again onjaq-syn
.