Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): export core functions based on enabled features #174

Closed
wants to merge 1 commit into from

Conversation

ssddOnTop
Copy link

The main idea behind this PR is that some applications are platform independent and they do not need std.

currently we have option for jaq_core::core() and jaq_core::minimal() but core needs all features to be enabled, there is no way that we can avoid excluding specific feature.

This pr adds new function feature_enabled which chains with feature flags

@ssddOnTop
Copy link
Author

I am not sure why we have core and minimal functions only but I have a

proposal: make all feature specific implementations, run and upd functions public so we don't have to update several functions on addition of each feature

@ssddOnTop ssddOnTop closed this May 5, 2024
@ssddOnTop ssddOnTop deleted the chore/add-non-std-core branch May 5, 2024 16:52
@01mf02
Copy link
Owner

01mf02 commented May 7, 2024

I know that you closed this issue, but it might still be worth to explain why I would not do it like this: In jaq, feature flags should not change the output of any function of a library crate. So enabling a feature flag should not make one function suddenly return more filters. However, it may expose new functions, which can be used in an application.

@ssddOnTop
Copy link
Author

I don't know if the feature flags are used anywhere else in the codebase, so I thought it would be good idea that people can only add feature they want and add functionality based on that

@ssddOnTop ssddOnTop restored the chore/add-non-std-core branch May 7, 2024 17:26
@ssddOnTop ssddOnTop deleted the chore/add-non-std-core branch May 7, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants