This repository was archived by the owner on Aug 5, 2022. It is now read-only.
ATLEDGE-464 SketchUpload recognizes Windows paths with spaces #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@calvinatintel @kmsywula please review |
|
@bbaltz505 |
|
@kmsywula I tested the script with my modifications added to your PR (21) and it worked fine. I'll rebase my PR once your PR is merged. |
|
@bbaltz505 Krzysztof's changes are in |
Signed-off-by: Brian Baltz <brian.a.baltz@intel.com>
|
Rebased onto latest HEAD. Will test tomorrow on a Windows VM I have configured for this error. |
|
Updated script works fine on Win7 with username containing a space (e.g., Arduino dir = "\users\Test User\AppData\Local\Arduino15". @kmsywula @calvinatintel please review |
|
@calvinatintel Please merge the changes. Will ask Noel to test it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue was found in Win XP. Verified fix on Win 7 system with username containing a space (Brian Baltz).