Fix Seeking with VC1 after 6702b01ee3598017f05374bfc7956493f790361c #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhaihao
referenced
this pull request
Aug 30, 2017
Intensity compensation was not present for B-frames, but only for P-frames. When a P-frame flags intensity compensation for its forward reference frame, all subsequent B-frames that use this reference frame as well, need to do intensity compensation as well.
|
I think GEN6 should have the same issue, could you fix this issue in gen6_mfd.c? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found some issues with kodi when seeking through VC-1 files after above commit was merged. It seems the priv_data is not checked for being null.
You can reproduce the issue when pausing / resuming VC-1 files. The gen8_mfd change was tested working.
Debuglog with backtrace: http://sprunge.us/PPWX
Sample to reproduce: http://milhouse.libreelec.tv/other/MKV9_vc-1_6ch_ac3_dts_pcm.mkv